Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pants: 1.5.0 -> 1.6.0 #40403

Merged
merged 1 commit into from May 12, 2018
Merged

pants: 1.5.0 -> 1.6.0 #40403

merged 1 commit into from May 12, 2018

Conversation

akazakov
Copy link
Contributor

@akazakov akazakov commented May 12, 2018 •
edited

Also fixing the missing dependency (wheel). Not sure when this
got broken, but 1.5.0 did not work either.

Motivation for this change

Update pantsbuild to the latest version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@akazakov
Update pants to 1.6.0
fbe7ebc 
Also fixing the missing dependency (wheel). Not sure when this
got broken, but 1.5.0 did not work either.
@akazakov
Copy link
Contributor Author

@copumpkin please take a look

@Mic92 Mic92 changed the title pants 1.5.0 -> 1.6.0 pants: 1.5.0 -> 1.6.0 May 12, 2018
@Mic92
Copy link
Member

Mic92 commented May 12, 2018

@GrahamcOfBorg build pants

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: pants

Partial log (click to expand)

writing entry points to src/pantsbuild.pants.egg-info/entry_points.txt
reading manifest file 'src/pantsbuild.pants.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'src/pantsbuild.pants.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pants

Partial log (click to expand)

reading manifest file 'src/pantsbuild.pants.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'src/pantsbuild.pants.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/7d2yhc96d0md4mb05b9m0wh07078z9h3-pantsbuild.pants-1.6.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pants

Partial log (click to expand)

writing entry points to src/pantsbuild.pants.egg-info/entry_points.txt
reading manifest file 'src/pantsbuild.pants.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'src/pantsbuild.pants.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK

@Mic92 Mic92 merged commit 2a61350 into NixOS:master May 12, 2018
@backuitist
Copy link
Contributor

Thanks that fixes #40405

@backuitist backuitist mentioned this pull request May 15, 2018
Closed
@backuitist
Copy link
Contributor

@akazakov I'm having an issue running pants 1.6.0:

Exception caught: (<type 'exceptions.ImportError'>)

Exception message: /tmp/tmpX7RCAD/native_engine.so: invalid ELF header

Does this work for you?

@copumpkin
Copy link
Member

@backuitist I assume you're on Linux? Can you check the file it complains about (with ldd or objdump or similar) and see if there's anything weird about it? At some point I had our pants package pre-downloading the native engine stuff but took that out because it was a pain to maintain. Now that a bug has been fixed in the darwin rust support (thanks @matthewbauer!) I want to make the native engine a proper source build again.

@backuitist
Copy link
Contributor

backuitist commented May 22, 2018 •
edited

Yes, I'm on Linux. That native_engine.so file is created in a (different) temporary directory for every call to pants and is deleted when the program returns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@akazakov @Mic92 @GrahamcOfBorg @backuitist @copumpkin