linuxPackages.kernel: config: fix DEBUG_INFO setting #40419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Success on aarch64-linux (full log) Attempted: linuxPackages.kernel Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: linuxPackages.kernel Partial log (click to expand)
|
andrew-d
reviewed
May 13, 2018
| @@ -37,7 +37,12 @@ with stdenv.lib; | |||
| DEBUG_STACKOVERFLOW n | |||
| SCHEDSTATS n | |||
| DETECT_HUNG_TASK y | |||
| DEBUG_INFO n # Not until we implement a separate debug output | |||
|
|
|||
| ${if (features.debug or false) then '' | |||
There was a problem hiding this comment.
OOC, why the features.debug or false; isn't the or false unnecessary?
|
OOC, why the `features.debug or false`; isn't the `or false` unnecessary?
Removing that will cause it to fail to evaluate because nothing sets this option by default. All other references to `features` do the same.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivial.