Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notmuch: 0.26.1 -> 0.26.2 #39727

Merged
merged 1 commit into from Apr 30, 2018
Merged

notmuch: 0.26.1 -> 0.26.2 #39727

merged 1 commit into from Apr 30, 2018

Conversation

bgamari
Copy link
Contributor

@bgamari bgamari commented Apr 30, 2018 •
edited

Motivation for this change

0.26.1 didn't pass the testsuite in my configuration.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Apr 30, 2018

cc @flokli

@flokli
Copy link
Contributor

flokli commented Apr 30, 2018

@bgamari This bump shouldn't fix the testsuite, but #39369 as soon as it gets merged from staging-18.03 to release-18.03.

@xeji
Copy link
Contributor

xeji commented Apr 30, 2018

@flokli this bump is for master.

0.26.1 didn't pass the testsuite in my configuration.

@bgamari I just built 0.26.1 on current master (1022dc5), all tests passed. What failed for you?

@bgamari
Copy link
Contributor Author

bgamari commented Apr 30, 2018 •
edited

@bgamari This bump shouldn't fix the testsuite, but #39369 as soon as it gets merged from staging-18.03 to release-18.03.

Ahh, I see; it must be fixed as I was building from master in that case.

@bgamari
Copy link
Contributor Author

bgamari commented Apr 30, 2018

@bgamari I just built 0.26.1 on current master (1022dc5), all tests passed. What failed for you?

Rather, it fails on release-18.03. Sorry for the confusion!

@xeji
Copy link
Contributor

xeji commented Apr 30, 2018

No problem 😃
@flokli, should we do this bump on master anyway?

@xeji
Copy link
Contributor

xeji commented Apr 30, 2018

@GrahamcOfBorg build notmuch afew alot python27Packages.notmuch python36Packages.notmuch

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: notmuch, afew, alot, python27Packages.notmuch, python36Packages.notmuch

Partial log (click to expand)


----------------------------------------------------------------------
Ran 4 tests in 0.138s

OK
/nix/store/9izqb2m3xz868vp7pcxq8icf64990sks-notmuch-0.26.2
/nix/store/3fczxgb4h5xakw8vhzyyn4z2hd09r0zr-afew-1.3.0
/nix/store/yb7bachsgs23rx91xw2il8wv5gqvynvx-python2.7-alot-0.7
/nix/store/ylw4ws1xvkx0bjc3wsdjj3rc8pvimkb4-python2.7-python-notmuch-0.26.2
/nix/store/y4wyrf7bgcd6dz4f5mmvzqysd78zjjcj-python3.6-python-notmuch-0.26.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: notmuch, afew, alot, python27Packages.notmuch, python36Packages.notmuch

Partial log (click to expand)


----------------------------------------------------------------------
Ran 4 tests in 0.213s

OK
/nix/store/4h7vahrzjs0yy0nwj1c9a7f4mzhq9wrc-notmuch-0.26.2
/nix/store/p0h0ls0cxr6swldb55rzc60c2x4pdddi-afew-1.3.0
/nix/store/s7nfcqn0dqs3z1wpd7baw1lkwj36z3hi-python2.7-alot-0.7
/nix/store/4jfwq4ssn7gzplyj7vlfi1ch76yv08k6-python2.7-python-notmuch-0.26.2
/nix/store/5pvp69swrfh28jz29arwpy1sch2z78h3-python3.6-python-notmuch-0.26.2

@flokli
Copy link
Contributor

flokli commented Apr 30, 2018

@xeji yes, bumping for master is fine :-)

I'd like to see this in release-18.03 as well (after #39369), due to the following fixes:

  • Break reference loops when indexing, fixes INTERNAL_ERROR in "notmuch show"
  • Don't call get_mset(0,0,X), fixes crash on some gcc8 using distros

@xeji
Copy link
Contributor

xeji commented Apr 30, 2018

I'd like to see this in release-18.03 as well (after #39369), due to the following fixes:

Makes sense, let's keep that in mind.

@xeji xeji merged commit f85222b into NixOS:master Apr 30, 2018
@flokli
Copy link
Contributor

flokli commented May 1, 2018

@xeji now that #39369 was meged, can you backport eaf71dd to release-18.03 too?

xeji pushed a commit that referenced this pull request May 1, 2018
@bgamari @xeji
notmuch: 0.26.1 -> 0.26.2
793f74a 
backport of #39727

(cherry picked from commit eaf71dd)
@xeji
Copy link
Contributor

xeji commented May 1, 2018

@flokli done.

@flokli
Copy link
Contributor

flokli commented May 1, 2018

@xeji awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bgamari @xeji @flokli @GrahamcOfBorg