Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dockerTools.buildImageWithNixDb: simplifications #39716

Closed
wants to merge 1 commit into from
Closed

dockerTools.buildImageWithNixDb: simplifications #39716

wants to merge 1 commit into from

Conversation

nlewo
Copy link
Member

@nlewo nlewo commented Apr 30, 2018

Since Nix 2 is now the stable Nix version, we can use closureInfo
which simplifies the Nix database initialisation (size and hash are
included in the "dump").

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@nlewo
dockerTools.buildImageWithNixDb: simplifications and switch to closur…
d6c6014 
…eInfo

Since Nix 2 is now the stable Nix version, we can use closureInfo
which simplifies the Nix database initialisation (size and hash are
included in the "dump").
@nlewo
Copy link
Member Author

nlewo commented Apr 30, 2018

@GrahamcOfBorg test docker-tools

@GrahamcOfBorg
Copy link

Success on aarch64-linux

Attempted: tests.docker-tools

No partial log is available.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.docker-tools

Partial log (click to expand)

docker: exit status 1
syncing
docker: running command: sync
docker: exit status 0
test script finished in 134.22s
cleaning up
killing docker (pid 593)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/rn4xz5m2mbrzwqvvwhy766hbyccdjnbg-vm-test-run-docker-tools

@grahamc
Copy link
Member

grahamc commented May 1, 2018

Unfortunately we shouldn't depend upon 2.0 yet.

@nlewo
Copy link
Member Author

nlewo commented May 1, 2018

@grahamc hmm, I'm surprised since VM build tools already depend of 2.0.
But I could resubmit this PR later since this is just to clean and simplify code base. Do you know when we could depend of 2.0?

@nlewo nlewo closed this May 1, 2018
@nlewo nlewo mentioned this pull request Sep 13, 2018
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nlewo @GrahamcOfBorg @grahamc