Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CB-300: Use postgres-slave instead of master in production #206

Merged
merged 1 commit into from Apr 30, 2018
Merged

CB-300: Use postgres-slave instead of master in production #206

merged 1 commit into from Apr 30, 2018

Conversation

paramsingh
Copy link
Collaborator

No description provided.

@paramsingh paramsingh changed the base branch from master to production April 30, 2018 17:07
mayhem
mayhem approved these changes Apr 30, 2018
View reviewed changes
Copy link
Member

@mayhem mayhem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that should work. Please deploy and verify that it works, otherwise revert and circle back around.

@paramsingh
Copy link
Collaborator Author

@brainzbot test this please

@paramsingh paramsingh merged commit fcc0fda into metabrainz:production Apr 30, 2018
@paramsingh paramsingh deleted the use-postgres-slave branch April 30, 2018 20:56
mwiencek
mwiencek reviewed May 3, 2018
View reviewed changes
consul_config.py.ctmpl
{{end}}
{{end}}

{{if service "postgres-slave"}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should use the pooler, via pgbouncer-slave. There's only a limited number of direct connections available.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, whoops. I'll fix and deploy today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwiencek mwiencek mwiencek left review comments

@mayhem mayhem mayhem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@paramsingh @mayhem @mwiencek