pam: Remove crossAttrs #40537
Merged
pam: Remove crossAttrs #40537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out none of this stuff is needed. The docs aren't evenly built properly anyways so the build trivially succeeds either way, due to what looks like upstream misunderstanding automake. If I try to build the docs manually in a cross shell (before and after this change), there's a make rule error such that some HTML files aren't even attempted to be built and then a copy fails. Even if this was all fixed, these been a good number of cross fixes upstream getting them to use CC_FOR_BUILD and other good stuff, so I doubt such hacks would be needed. Progress towards NixOS#40531 and NixOS#33302.
|
Success on x86_64-darwin (full log) Attempted: pam Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: pam Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: pam Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out none of this stuff is needed. The docs aren't evenly built
properly anyways so the build trivially succeeds either way, due to what
looks like upstream misunderstanding automake. If I try to build the
docs manually in a cross shell (before and after this change), there's a
make rule error such that some HTML files aren't even attempted to be
built and then a copy fails.
Even if this was all fixed, these been a good number of cross fixes
upstream getting them to use CC_FOR_BUILD and other good stuff, so I
doubt such hacks would be needed.
Motivation for this change
Progress towards #40531 and #33302.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)