Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MinGW, Hurd: Clean ups and crossConfig removal #40532

Merged
merged 2 commits into from May 15, 2018

Conversation

Ericson2314
Copy link
Member

Motivation for this change

Backport of #40530. The mingw changes might actually be useful for stable. The Hurd changes certainly aren't, but are useful for other refactors which are staging relevant.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Style of dual implementation and headers derivations is take from
bb7067f.
This stuff is horribly bit-rotted anyways, but I'm getting rid of
crossConfig so it must be changed.
@Ericson2314 Ericson2314 merged commit 7a8f0b3 into NixOS:release-18.03 May 15, 2018
@Ericson2314 Ericson2314 deleted the mingw-cleanup branch May 15, 2018 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants