Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.asyncssh: init at 1.13.0 #40527

Merged
merged 2 commits into from May 22, 2018
Merged

pythonPackages.asyncssh: init at 1.13.0 #40527

merged 2 commits into from May 22, 2018

Conversation

worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented May 14, 2018 •
edited

Motivation for this change

I needed this

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace requested a review from FRidh as a code owner May 14, 2018 23:13
FRidh
FRidh reviewed May 15, 2018
View reviewed changes
pkgs/development/python-modules/asyncssh/default.nix Outdated
version = "1.12.2";
disabled = pythonOlder "3.4";

doCheck = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the default, please drop

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoroughly dropped

@FRidh
Copy link
Member

FRidh commented May 15, 2018

@GrahamcOfBorg build python2.pkgs.asyncssh python3.pkgs.asyncssh

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: python2.pkgs.asyncssh, python3.pkgs.asyncssh

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: python3.pkgs.asyncssh

The following builds were skipped because they don't evaluate on x86_64-linux: python2.pkgs.asyncssh

Partial log (click to expand)








error: Test failed: <unittest.runner.TextTestResult run=845 errors=1 failures=0>
builder for '/nix/store/xq13ylrk7kpnwqb9cwly38j94y3k3wxf-python3.6-asyncssh-1.12.2.drv' failed with exit code 1
error: build of '/nix/store/xq13ylrk7kpnwqb9cwly38j94y3k3wxf-python3.6-asyncssh-1.12.2.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: python3.pkgs.asyncssh

The following builds were skipped because they don't evaluate on aarch64-linux: python2.pkgs.asyncssh

Partial log (click to expand)








error: Test failed: <unittest.runner.TextTestResult run=845 errors=1 failures=0>
builder for '/nix/store/4hp7gpjsx1z6xrl44mcw7yvxpkxz6wm7-python3.6-asyncssh-1.12.2.drv' failed with exit code 1
�[31;1merror:�[0m build of '/nix/store/4hp7gpjsx1z6xrl44mcw7yvxpkxz6wm7-python3.6-asyncssh-1.12.2.drv' failed

@FRidh
Copy link
Member

FRidh commented May 15, 2018

This needs some fixing:

======================================================================
ERROR: sspi_stub (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: sspi_stub
Traceback (most recent call last):
  File "/nix/store/96wn2gz3mwi71gwcrvpfg39bsymd7gqx-python3-3.6.5/lib/python3.6/unittest/loader.py", line 153, in loadTestsFromName
    module = __import__(module_name)
  File "/build/asyncssh-1.12.2/tests/sspi_stub.py", line 15, in <module>
    from asyncssh.gss_win32 import ASC_RET_INTEGRITY, ISC_RET_INTEGRITY
  File "/build/asyncssh-1.12.2/asyncssh/gss_win32.py", line 18, in <module>
    from sspi import ClientAuth, ServerAuth
ModuleNotFoundError: No module named 'sspi'
----------------------------------------------------------------------
Ran 845 tests in 276.445s
FAILED (errors=1, skipped=24)
Test failed: <unittest.runner.TextTestResult run=845 errors=1 failures=0>
/bin/sh: openssl: not found
/bin/sh: ssh: not found

@worldofpeace
Copy link
Contributor Author

@FRidh Can I just kill it :)

@worldofpeace
Copy link
Contributor Author

@FRidh Can you check if this builds? I've made all requested changes and then some.

dotlambda
dotlambda reviewed May 22, 2018
View reviewed changes
pkgs/development/python-modules/asyncssh/default.nix Outdated
pyopenssl
];

patches = [ ./ASYNCSSH-1.12.2_sspi-stub.patch ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer deleting the file using rm in postPatch. And please add a comment why it is deleted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

dotlambda
dotlambda reviewed May 22, 2018
View reviewed changes
pkgs/development/python-modules/asyncssh/default.nix Outdated
@@ -0,0 +1,33 @@
{ stdenv, buildPythonPackage, fetchPypi, pythonOlder, isPy34, isPy35, isPy36
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isPy34, isPy35, isPy36 are not used

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@worldofpeace
Copy link
Contributor Author

Just saw that this package is now old.

@dotlambda
Copy link
Member

@worldofpeace In that case, update this PR to use the most recent version.

@GrahamcOfBorg build python3.pkgs.asyncssh

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python3.pkgs.asyncssh

Partial log (click to expand)










/nix/store/yjb809hhcq2fp0rxzk09zy9q4hd2iygx-python3.6-asyncssh-1.12.2

@dotlambda
Copy link
Member

In order to fix

OK (skipped=14)
/bin/sh: openssl: not found
/bin/sh: ssh: not found

we'd probably have to add openssl and openssh to checkInputs. But we don't need to because the tests seem to be skipped when the executables are not present.

@dotlambda dotlambda changed the title pythonPackages.asyncssh: init at 1.12.2 pythonPackages.asyncssh: init at 1.13.0 May 22, 2018
@dotlambda
Copy link
Member

@GrahamcOfBorg build python3.pkgs.asyncssh

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python3.pkgs.asyncssh

Partial log (click to expand)










/nix/store/9dkc71kxg02bvg67k55mmpgci8m7nn1q-python3.6-asyncssh-1.12.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python3.pkgs.asyncssh

Partial log (click to expand)

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python3.pkgs.asyncssh

Partial log (click to expand)










/nix/store/scmjhfkl7sbya28g37syah2sxpsjm66v-python3.6-asyncssh-1.13.0

@dotlambda dotlambda merged commit b9bdd7d into NixOS:master May 22, 2018
@dotlambda
Copy link
Member

Thanks!

@worldofpeace worldofpeace deleted the python-asyncssh branch May 22, 2018 22:11
@worldofpeace
Copy link
Contributor Author

Yay! Thank you for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

@dotlambda dotlambda dotlambda left review comments

Assignees
No one assigned
Labels
2.status: work-in-progress 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@worldofpeace @FRidh @GrahamcOfBorg @dotlambda