Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MinGW, Hurd: Clean ups and crossConfig removal #40530

Merged
merged 2 commits into from May 15, 2018

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented May 15, 2018

Motivation for this change

The MinGW stuff might actually be useful, and now its definitely in a better state. In both cases I'm trying to pure crossConfig, and these derivations are good place to begin because there's definitely no mass-rebuild.

Progress towards #40531

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Style of dual implementation and headers derivations is take from
bb7067f.
This stuff is horribly bit-rotted anyways, but I'm getting rid of
crossConfig so it must be changed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants