Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcc,gcc8: {revert gcc to gcc7, mark gcc8 as broken} on Darwin #40519

Merged
merged 5 commits into from May 15, 2018
Merged

gcc,gcc8: {revert gcc to gcc7, mark gcc8 as broken} on Darwin #40519

merged 5 commits into from May 15, 2018

Conversation

Synthetica9
Copy link
Member

Motivation for this change

See #40038.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label May 14, 2018
@matthewbauer
Copy link
Member

There must still be a job using gcc8. Eval is broken.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gcc, gcc8

Partial log (click to expand)

copying path '/nix/store/33c8a50j2y88fdphfad4djwh15d83k57-gmp-6.1.2' from 'https://cache.nixos.org'...
copying path '/nix/store/cri63x8l32bc8xd9mjdh82yj83zilzp7-isl-0.17.1' from 'https://cache.nixos.org'...
copying path '/nix/store/n36n105sl9q941j7i3dgjyy14q6pfgf8-mpfr-3.1.6' from 'https://cache.nixos.org'...
copying path '/nix/store/h1cyqczm4nhki42s3594jmnhw98v42w7-libmpc-1.1.0' from 'https://cache.nixos.org'...
copying path '/nix/store/l1a62azcp0sg6j7xx2qz99ws7d0487cr-gcc-8.1.0' from 'https://cache.nixos.org'...
copying path '/nix/store/z3vgm02abfsyz3km7g5lrz5gryvp3zs3-binutils-wrapper-2.30' from 'https://cache.nixos.org'...
copying path '/nix/store/0mj9rpg0sy6hq6npqni0hm8f5vykskv9-gcc-wrapper-8.1.0' from 'https://cache.nixos.org'...
copying path '/nix/store/w8hl7hhqi1p0ps3fdx6xmcv4knzax1p5-gcc-wrapper-8.1.0' from 'https://cache.nixos.org'...
/nix/store/w8hl7hhqi1p0ps3fdx6xmcv4knzax1p5-gcc-wrapper-8.1.0
/nix/store/0mj9rpg0sy6hq6npqni0hm8f5vykskv9-gcc-wrapper-8.1.0

@Synthetica9
Copy link
Member Author

✔️

@matthewbauer @Synthetica9
release: disable tests.cc-wrapper-gcc8.x86_64-darwin
68cedc0 
This test is broken because gcc8.x86_64-darwin is broken. Please add
the test back in once we have fixed it!

Job: https://hydra.nixos.org/job/nixpkgs/trunk/gcc8.x86_64-darwin
Issue: NixOS#40038
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gcc, gcc8

Partial log (click to expand)

/nix/store/w8hl7hhqi1p0ps3fdx6xmcv4knzax1p5-gcc-wrapper-8.1.0
/nix/store/0mj9rpg0sy6hq6npqni0hm8f5vykskv9-gcc-wrapper-8.1.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gcc, gcc8

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/hpf6m0i97yarzzq8kysscjy65sb8dj1c-gcc-wrapper-8.1.0
strip is /nix/store/85wqgd5aj4g57g1fsrnmdbq4mf1kz957-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hpf6m0i97yarzzq8kysscjy65sb8dj1c-gcc-wrapper-8.1.0/bin
patching script interpreter paths in /nix/store/hpf6m0i97yarzzq8kysscjy65sb8dj1c-gcc-wrapper-8.1.0
checking for references to /build in /nix/store/hpf6m0i97yarzzq8kysscjy65sb8dj1c-gcc-wrapper-8.1.0...
strip is /nix/store/85wqgd5aj4g57g1fsrnmdbq4mf1kz957-binutils-2.30/bin/strip
strip is /nix/store/85wqgd5aj4g57g1fsrnmdbq4mf1kz957-binutils-2.30/bin/strip
/nix/store/kipwb9z13wdkkd7p8d69ni2pqs5c27f3-gcc-wrapper-8.1.0
/nix/store/hpf6m0i97yarzzq8kysscjy65sb8dj1c-gcc-wrapper-8.1.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gcc, gcc8

Partial log (click to expand)

these derivations will be built:
  /nix/store/m7024xz3nhany5kl1r8hn5f0lvg4nhww-gcc-8.1.0.drv
  /nix/store/d5bsa4a97fw298w33wbgma60fzpbc5rg-gcc-wrapper-8.1.0.drv
waiting for locks or build slots...
/nix/store/kipwb9z13wdkkd7p8d69ni2pqs5c27f3-gcc-wrapper-8.1.0
/nix/store/hpf6m0i97yarzzq8kysscjy65sb8dj1c-gcc-wrapper-8.1.0

@Synthetica9
Copy link
Member Author

@matthewbauer merge?

@matthewbauer matthewbauer merged commit da5a692 into NixOS:gcc8 May 15, 2018
@L-as
Copy link
Member

L-as commented May 26, 2019

Since that issue is closed now, should this be reverted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501+ 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Synthetica9 @matthewbauer @GrahamcOfBorg @L-as