Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discord: 0.0.4 -> 0.0.5 #40517

Closed
wants to merge 1 commit into from
Closed

discord: 0.0.4 -> 0.0.5 #40517

wants to merge 1 commit into from

Conversation

TravisWhitehead
Copy link

@TravisWhitehead TravisWhitehead commented May 14, 2018 •
edited

Motivation for this change

Discord breaks on every version change. This has been fixed in master, but not yet in release-18.03. (I'm not sure if this is the correct way to backport, please correct me if not.)

cc @MP2E

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented May 15, 2018

For a backport, please git cherry-pick -x the original commit from master so we can track the origin of this change.

In the future, if a change needs backporting, please mention that in your original PR. In most cases the person merging it can do the backport right away, so there's no need for a second PR.

@MP2E
Copy link

MP2E commented May 15, 2018

thanks for the report, fixed as of 6f7f687

@MP2E MP2E closed this May 15, 2018
@TravisWhitehead TravisWhitehead deleted the release-18.03-discord-0.0.5 branch May 15, 2018 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@TravisWhitehead @xeji @MP2E @GrahamcOfBorg @lightdiscord