compsize: init at 2018-04-07 #40217
Merged
compsize: init at 2018-04-07 #40217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xeji
reviewed
May 12, 2018
| sha256 = "0jps8n0xsdh4mcww5q29rzysbv50iq6rmihxrf99lzgrw0sw5m7k"; | ||
| }; | ||
|
|
||
| nativeBuildInputs = [ btrfs-progs ]; |
There was a problem hiding this comment.
This should be buildInputs (not nativeBuildInputs): the actual btrfs tools don't need to run on the machine where you build this but the build includes some btrfs headers for the target platform. Doesn't make a difference unless you're cross-building but let's get this right anyway.
The distinction is rather subtle, see https://nixos.org/nixpkgs/manual/#ssec-stdenv-dependencies.
Simple rule of thumb: if it needs to run during the build process, put it in nativeBuildInputs.
CrazedProgrammer
force-pushed
the
compsize
branch
2 times, most recently
from
07442ae
to
9b82bf6
Compare
CrazedProgrammer
force-pushed
the
compsize
branch
from
9b82bf6
to
5363414
Compare
|
Fixed. |
|
@GrahamcOfBorg build compsize |
|
Success on x86_64-linux (full log) Attempted: compsize Partial log (click to expand)
|
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: compsize Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: compsize Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Adds compsize, a tool for checking the compression type/ratio on a file or a set of files on Btrfs.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)