Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatter: correctly handle annotation path #6084

Merged
merged 1 commit into from May 9, 2018
Merged

Formatter: correctly handle annotation path #6084

merged 1 commit into from May 9, 2018

Conversation

asterite
Copy link
Member

@asterite asterite commented May 9, 2018

When annotations were introduced, I forgot to correctly format their name/path, now that it can have :: and all that stuff. Thanks @kostya for spotting this.

@asterite asterite self-assigned this May 9, 2018
@RX14 RX14 added this to the Next milestone May 9, 2018
@asterite asterite merged commit 0e64622 into crystal-lang:master May 9, 2018
@asterite asterite mentioned this pull request May 19, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdogruyol sdogruyol sdogruyol approved these changes

@RX14 RX14 RX14 approved these changes

Assignees

@asterite asterite

Labels
kind:bug topic:compiler topic:tools:formatter topic:tools
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asterite @sdogruyol @RX14