Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

monero: fix daemon crash #40212

Merged
merged 1 commit into from
May 9, 2018
Merged

monero: fix daemon crash #40212

merged 1 commit into from
May 9, 2018
+10 −1

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented May 9, 2018

Motivation for this change

A recent transaction in the mempool is causing the monero daemon to crash

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: monero

Partial log (click to expand)

shrinking /nix/store/26dhvzz3fbvbfql06ppxwj303hw9pha2-monero-0.12.0.0/bin/monerod
shrinking /nix/store/26dhvzz3fbvbfql06ppxwj303hw9pha2-monero-0.12.0.0/bin/monero-blockchain-import
shrinking /nix/store/26dhvzz3fbvbfql06ppxwj303hw9pha2-monero-0.12.0.0/bin/monero-blockchain-export
shrinking /nix/store/26dhvzz3fbvbfql06ppxwj303hw9pha2-monero-0.12.0.0/bin/monero-blockchain-blackball
shrinking /nix/store/26dhvzz3fbvbfql06ppxwj303hw9pha2-monero-0.12.0.0/bin/monero-blockchain-usage
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/26dhvzz3fbvbfql06ppxwj303hw9pha2-monero-0.12.0.0/lib  /nix/store/26dhvzz3fbvbfql06ppxwj303hw9pha2-monero-0.12.0.0/bin
patching script interpreter paths in /nix/store/26dhvzz3fbvbfql06ppxwj303hw9pha2-monero-0.12.0.0
checking for references to /build in /nix/store/26dhvzz3fbvbfql06ppxwj303hw9pha2-monero-0.12.0.0...
/nix/store/26dhvzz3fbvbfql06ppxwj303hw9pha2-monero-0.12.0.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: monero

Partial log (click to expand)

-- Installing: /nix/store/4qa063hdhlfkhji2vc0p32g6xq2bc59a-monero-0.12.0.0/bin/monerod
-- Installing: /nix/store/4qa063hdhlfkhji2vc0p32g6xq2bc59a-monero-0.12.0.0/bin/monero-blockchain-import
-- Installing: /nix/store/4qa063hdhlfkhji2vc0p32g6xq2bc59a-monero-0.12.0.0/bin/monero-blockchain-export
-- Installing: /nix/store/4qa063hdhlfkhji2vc0p32g6xq2bc59a-monero-0.12.0.0/bin/monero-blockchain-blackball
-- Installing: /nix/store/4qa063hdhlfkhji2vc0p32g6xq2bc59a-monero-0.12.0.0/bin/monero-blockchain-usage
post-installation fixup
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/4qa063hdhlfkhji2vc0p32g6xq2bc59a-monero-0.12.0.0/lib  /nix/store/4qa063hdhlfkhji2vc0p32g6xq2bc59a-monero-0.12.0.0/bin
patching script interpreter paths in /nix/store/4qa063hdhlfkhji2vc0p32g6xq2bc59a-monero-0.12.0.0
/nix/store/4qa063hdhlfkhji2vc0p32g6xq2bc59a-monero-0.12.0.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: monero

Partial log (click to expand)

shrinking /nix/store/xyr14yd95l4vpi9f7x9il9cah3lsl67i-monero-0.12.0.0/bin/monero-blockchain-import
shrinking /nix/store/xyr14yd95l4vpi9f7x9il9cah3lsl67i-monero-0.12.0.0/bin/monerod
shrinking /nix/store/xyr14yd95l4vpi9f7x9il9cah3lsl67i-monero-0.12.0.0/bin/monero-gen-trusted-multisig
shrinking /nix/store/xyr14yd95l4vpi9f7x9il9cah3lsl67i-monero-0.12.0.0/bin/monero-wallet-cli
shrinking /nix/store/xyr14yd95l4vpi9f7x9il9cah3lsl67i-monero-0.12.0.0/bin/monero-wallet-rpc
strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xyr14yd95l4vpi9f7x9il9cah3lsl67i-monero-0.12.0.0/lib  /nix/store/xyr14yd95l4vpi9f7x9il9cah3lsl67i-monero-0.12.0.0/bin
patching script interpreter paths in /nix/store/xyr14yd95l4vpi9f7x9il9cah3lsl67i-monero-0.12.0.0
checking for references to /build in /nix/store/xyr14yd95l4vpi9f7x9il9cah3lsl67i-monero-0.12.0.0...
/nix/store/xyr14yd95l4vpi9f7x9il9cah3lsl67i-monero-0.12.0.0

@xeji xeji merged commit 941054a into NixOS:master May 9, 2018
@rnhmjoj rnhmjoj deleted the monero-fix branch February 23, 2019 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rnhmjoj @GrahamcOfBorg @xeji