Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RDY] pythonPackages.configobj: enable tests #40231

Merged
merged 1 commit into from May 11, 2018
Merged

[RDY] pythonPackages.configobj: enable tests #40231

merged 1 commit into from May 11, 2018

Conversation

teto
Copy link
Member

@teto teto commented May 9, 2018 •
edited

Motivation for this change

I found a bug in configobj and wanted to run the testsuite to check
things. Now that it works let's upstream it.

Things done

I disabled the only failing tests. Seems too minor to request an upstream change. I download the source from github since it 's not available on Pipy

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@teto teto requested a review from FRidh as a code owner May 9, 2018 15:56
@teto teto changed the title pythonPackages.configobj: enable tests [RDY] pythonPackages.configobj: enable tests May 9, 2018
@xeji
Copy link
Contributor

xeji commented May 9, 2018

cc @etu

dotlambda
dotlambda reviewed May 10, 2018
View reviewed changes
pkgs/development/python-modules/configobj/default.nix Outdated
src = fetchPypi {
inherit pname version;
sha256 = "00h9rcmws03xvdlfni11yb60bz3kxfvsj6dg6nrpzj71f03nbxd2";
src = fetchFromGitHub {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to add a comment on why you're fetching from GitHub.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@teto
pythonPackages.configobj: enable tests
eb2ba8a 
I found a bug in configobj and wanted to run the testsuite to confirm it
was a bugs rather than a nixos oddity. Now that tests work let's upstream it.
@adisbladis
Copy link
Member

@GrahamcOfBorg build python2Packages.configobj python3Packages.configobj

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2Packages.configobj, python3Packages.configobj

Partial log (click to expand)

collected 71 items / 1 deselected

tests/test_configobj.py ................................................ [ 68%]
.............                                                            [ 87%]
tests/test_validate.py ...                                               [ 91%]
tests/test_validate_errors.py ......                                     [100%]

=================== 70 passed, 1 deselected in 0.26 seconds ====================
/nix/store/mpmhisj7kqk7g5gp3xkcbv4vqsilxv3q-python2.7-configobj-5.0.6
/nix/store/q1wnw4rls3rwgygv199qqb6rch0spz08-python3.6-configobj-5.0.6

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python2Packages.configobj, python3Packages.configobj

Partial log (click to expand)

collected 71 items / 1 deselected

tests/test_configobj.py ................................................ [ 68%]
.............                                                            [ 87%]
tests/test_validate.py ...                                               [ 91%]
tests/test_validate_errors.py ......                                     [100%]

=================== 70 passed, 1 deselected in 0.31 seconds ====================
/nix/store/cigzva1akn81vf7cgndlnhq1r8rmzvir-python2.7-configobj-5.0.6
/nix/store/6gr90a7x5i6lxi5bb00ya5k4zd4yhvyx-python3.6-configobj-5.0.6

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2Packages.configobj, python3Packages.configobj

Partial log (click to expand)

collected 71 items / 1 deselected

tests/test_configobj.py ................................................ [ 68%]
.............                                                            [ 87%]
tests/test_validate.py ...                                               [ 91%]
tests/test_validate_errors.py ......                                     [100%]

=================== 70 passed, 1 deselected in 1.84 seconds ====================
/nix/store/qm4sfj8v81npk9924waxpiihblh83z02-python2.7-configobj-5.0.6
/nix/store/ajw61kl88biay4jwnz8ppvfa9zx4dlhg-python3.6-configobj-5.0.6

@adisbladis adisbladis merged commit c361d5a into NixOS:master May 11, 2018
@teto teto deleted the configobj_tests branch May 11, 2018 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@teto @xeji @adisbladis @GrahamcOfBorg @dotlambda