Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libomxil-bellagio: fix build on gcc8 #40227

Merged
merged 1 commit into from
May 9, 2018
Merged

libomxil-bellagio: fix build on gcc8 #40227

merged 1 commit into from
May 9, 2018
+4 −0

Conversation

Synthetica9
Copy link
Member

Added the -Wno-error=array-bounds flag. Fixes #40213.

Motivation for this change

See #40213.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@Synthetica9
libomxil-bellagio: fix build on gcc8
804b708 
Added the `-Wno-error=array-bounds` flag. Fixes NixOS#40213.
@Synthetica9
Copy link
Member Author

Yeah, that rebuild was to be expected...

@globin globin merged commit c10842f into NixOS:gcc8 May 9, 2018
@Synthetica9 Synthetica9 deleted the libomxil-bellagio-gcc8-fix branch May 9, 2018 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Synthetica9 @globin @GrahamcOfBorg