Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eid-mw 4.1.19 -> 4.4.1 #40229

Closed
wants to merge 3 commits into from
Closed

eid-mw 4.1.19 -> 4.4.1 #40229

wants to merge 3 commits into from
+34 −61

Conversation

bfortz
Copy link
Contributor

@bfortz bfortz commented May 9, 2018

Motivation for this change

Urgent version bump as tax season is coming and 4.1.19 is not compatible with firefox anymore.

eid-viewer was merged upstream with eid-mw, so it is included here now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

bfortz added 3 commits May 9, 2018 11:24
@bfortz
eid-mw: 4.1.19 -> 4.3.7
f4067f7 
Urgent version bump as tax season is coming and 4.1.19 is not compatible
with firefox anymore.
@bfortz
eid-mw: 4.1.19 -> 4.4.1
733fe31 
Urgent version bump as tax season is coming and 4.1.19 is not compatible
with firefox anymore.

eid-viewer was merged upstream with eid-mw, so it is included here now.
@bfortz
eid-mw: 4.1.19 -> 4.4.1
2975441 
Urgent version bump as tax season is coming and 4.1.19 is not compatible
with firefox anymore.

eid-viewer was merged upstream with eid-mw, so it is included here now.
@xeji
Copy link
Contributor

xeji commented May 9, 2018

There's no need to go to staging-18.03 here since this does not involve a mass rebuild.

Since this is a backport of #40012, please open a new PR based on release-18.03 and cherry-pick your original commits from master using git cherry-pick -x so we can trace their origin.

In the future, please mention in your original PR if it needs a backport to the stable release. In most cases, the person merging it can also backport without you opening a separate pull request.

@xeji xeji closed this May 9, 2018
@bfortz bfortz deleted the eid-mw-4.4.1 branch May 9, 2018 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bfortz @xeji