Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/tests/statsd: fix non-deterministic failure #40214

Merged
merged 1 commit into from
May 9, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented May 9, 2018

Motivation for this change

Test failed sometimes on Hydra because the service wasn't ready immediately after starting the systemd unit.

Fixed by waiting for the service to accept a connection.

Test failed sometimes because the service took more time to start.
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 9, 2018
@srhb srhb merged commit 2ea084e into NixOS:master May 9, 2018
@xeji xeji deleted the fix-statsd-test branch May 9, 2018 15:10
@xeji xeji mentioned this pull request May 9, 2018
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants