Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CKAN GUI throws "module not found"-error again and again #2419

Closed
DasSkelett opened this issue Apr 22, 2018 · 3 comments · Fixed by #2425
Closed

CKAN GUI throws "module not found"-error again and again #2419

DasSkelett opened this issue Apr 22, 2018 · 3 comments · Fixed by #2425
Assignees
Labels
GUI Issues affecting the interactive GUI Relationships Issues affecting depends, recommends, etc.

Comments

@DasSkelett
Copy link
Member

DasSkelett commented Apr 22, 2018

Background

CKAN Version:
v1.25.0

KSP version
v1.4.2.2110

Operating System:
Windows10 64bit

Problem

What steps did you take in CKAN?
Selected AJE Extended by seanyoung247.
CKAN raised error:

Module AdvancedJetEngine has not been found.
This may be because it is not compatible with the currently installed version of KSP

Clicked Dismiss and selected different mod to install (with AJE Extended still checked!).

What did you expect to happen?
Nothing.

What happened instead?
CKAN throws the error again on each new selection AND deselection of other mods as long as AJE is selected.

What should happen?
CKAN already deenables the Apply changes-button, so there is no need to inform the user again and again (which happens surely not intentional).

@HebaruSan HebaruSan added GUI Issues affecting the interactive GUI Relationships Issues affecting depends, recommends, etc. labels Apr 22, 2018
@HebaruSan
Copy link
Member

This is happening because AJE Extended depends on AJE which depends on FAR, and FAR isn't available for 1.4.2 (the forum thread title says specifically 1.3.1). So at one level this is a duplicate of #2231, since AJE Extended should be marked as incompatible (note that AJE itself is marked incompatible because of the incompatible dependency, but that doesn't propagate through multiple levels of dependencies).

At another level, it would be nice to automatically uncheck AJE Extended after the error is dismissed. Not sure how feasible that would be.

@DasSkelett
Copy link
Member Author

Yes, the first level doesn't matter to me, as I just wanted to install it for testing pusposes for #2416 :D
I think your second approach is the way to go, as just suppressing the error is both more complicated (I think, didn't check the code yet) and also not recommended, because suppressing errors always is a welcome opportunity for more errors to sneak in.

@KSP-CKAN KSP-CKAN deleted a comment from DasSkelett Apr 24, 2018
@HebaruSan
Copy link
Member

This should be easy, but WinForms continues to embody the principle of maximum surprise by not changing the checkbox's display until after I click somewhere else in the grid. The (new) code to uncheck the box runs, the mod is removed from the changeset, but the UI is sitting there with a check mark in the box. It's a wonder to me that people have been able to get anything done with this toolkit at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI Issues affecting the interactive GUI Relationships Issues affecting depends, recommends, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants