nixos-enter: Ensures presence of full /sys tree. (for efivarfs) #39342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This partially reverts a change from e88f289 which removed the `mount --rbind /sys`. While true that the activation scripts will mount `sysfs` at `/sys`, none of the mountpoints lower in the `/sys` tree are handled by the activation script, which includes `efivarfs`. This fixes NixOS#38477 since it ensures the presence of `efivarfs` in the `/sys` tree, which is why the systemd-boot installation failed.
7c6f434c
added a commit
that referenced
this pull request
Apr 23, 2018
nixos-enter: Ensures presence of full /sys tree. (for efivarfs) (cherry picked from commit 6048470)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially reverts a change from e88f289 which removed the
mount --rbind /sys.While true that the activation scripts will mount
sysfsat/sys, none of the mountpoints lower in the/systree are handled by the activation script, which includesefivarfs.Motivation for this change
This fixes #38477 since it ensures the presence of
efivarfsin the/systree, which is why the systemd-boot installation failed.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)Tested by:
exec qemu-system-x86_64 --enable-kvm -bios /nix/store/qcc1qxnmzg4phgij3ap7v3yq4yhaxiqc-OVMF-2017-12-05-fd/FV/OVMF.fd -device e1000,netdev=net0 -netdev user,id=net0 -m 4G -cdrom /nix/store/i6a4v4jpn1016iipzsqlw9f83a9vh2f7-nixos-18.03.git.06c576b-x86_64-linux.iso/iso/nixos-18.03.git.06c576b-x86_64-linux.iso -hda hdd.img; The actual path for the OVMF bios will change.nixos-installandnixos-enterwork, without any warning or weirdness.Things to do