Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

procps-ng: 3.3.13 -> 3.3.14 #39337

Closed
wants to merge 1 commit into from
Closed

procps-ng: 3.3.13 -> 3.3.14 #39337

wants to merge 1 commit into from

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Apr 22, 2018

Motivation for this change

The sha256 on the package was wrong when building from source, and after fixing the sha256 I noticed the patches no longer applied. I suspect the upstream maintainer backported the fixes into the 3.3.13 release.

At any rate, the new release fixes issue 88:
https://gitlab.com/procps-ng/procps/tags

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@bhipple
procps-ng: 3.3.13 -> 3.3.14
646ff73 
Upgrading to the latest release, which fixes the issues previously requiring patches.
@bhipple
Copy link
Contributor Author

bhipple commented Apr 22, 2018

@GrahamcOfBorg build procps-ng

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: procps-ng

Partial log (click to expand)

shrinking /nix/store/l1psmkc7fy1l28qxnxhz5n2whm2y4hgi-procps-3.3.14/bin/slabtop
shrinking /nix/store/l1psmkc7fy1l28qxnxhz5n2whm2y4hgi-procps-3.3.14/bin/watch
shrinking /nix/store/l1psmkc7fy1l28qxnxhz5n2whm2y4hgi-procps-3.3.14/bin/top
shrinking /nix/store/l1psmkc7fy1l28qxnxhz5n2whm2y4hgi-procps-3.3.14/sbin/sysctl
gzipping man pages under /nix/store/l1psmkc7fy1l28qxnxhz5n2whm2y4hgi-procps-3.3.14/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/l1psmkc7fy1l28qxnxhz5n2whm2y4hgi-procps-3.3.14/lib  /nix/store/l1psmkc7fy1l28qxnxhz5n2whm2y4hgi-procps-3.3.14/bin  /nix/store/l1psmkc7fy1l28qxnxhz5n2whm2y4hgi-procps-3.3.14/sbin
patching script interpreter paths in /nix/store/l1psmkc7fy1l28qxnxhz5n2whm2y4hgi-procps-3.3.14
checking for references to /build in /nix/store/l1psmkc7fy1l28qxnxhz5n2whm2y4hgi-procps-3.3.14...
moving /nix/store/l1psmkc7fy1l28qxnxhz5n2whm2y4hgi-procps-3.3.14/sbin/* to /nix/store/l1psmkc7fy1l28qxnxhz5n2whm2y4hgi-procps-3.3.14/bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: procps-ng

Partial log (click to expand)

shrinking /nix/store/ksq96h04674szi22lzifhhxm3i62snsb-procps-3.3.14/bin/free
shrinking /nix/store/ksq96h04674szi22lzifhhxm3i62snsb-procps-3.3.14/bin/ps
shrinking /nix/store/ksq96h04674szi22lzifhhxm3i62snsb-procps-3.3.14/lib/libprocps.so.6.1.0
gzipping man pages under /nix/store/ksq96h04674szi22lzifhhxm3i62snsb-procps-3.3.14/share/man/
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ksq96h04674szi22lzifhhxm3i62snsb-procps-3.3.14/lib  /nix/store/ksq96h04674szi22lzifhhxm3i62snsb-procps-3.3.14/bin  /nix/store/ksq96h04674szi22lzifhhxm3i62snsb-procps-3.3.14/sbin
patching script interpreter paths in /nix/store/ksq96h04674szi22lzifhhxm3i62snsb-procps-3.3.14
checking for references to /build in /nix/store/ksq96h04674szi22lzifhhxm3i62snsb-procps-3.3.14...
moving /nix/store/ksq96h04674szi22lzifhhxm3i62snsb-procps-3.3.14/sbin/* to /nix/store/ksq96h04674szi22lzifhhxm3i62snsb-procps-3.3.14/bin
/nix/store/ksq96h04674szi22lzifhhxm3i62snsb-procps-3.3.14

@bhipple
Copy link
Contributor Author

bhipple commented Apr 22, 2018 •
edited

CC @typetetris @dtzWill let me know if there's anything in particular I should be testing. I have a non-standard location nix store and noticed this one is now refusing to build if you skip the Hydra cache, since upstream appears to have moved.

@matthewbauer
Copy link
Member

Thanks but @dtzWill has already merged this into staging in 54c6a9c.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: procps-ng

Partial log (click to expand)

/nix/store/l1psmkc7fy1l28qxnxhz5n2whm2y4hgi-procps-3.3.14

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: procps-ng

Partial log (click to expand)

/nix/store/ksq96h04674szi22lzifhhxm3i62snsb-procps-3.3.14

@bhipple
Copy link
Contributor Author

bhipple commented Apr 22, 2018

Ah perfect, thanks for the heads up Matthew! I just checked on master; should've thought to double-check staging as well for this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bhipple @GrahamcOfBorg @matthewbauer