Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mono: add vulnerabilities #39344

Merged
merged 2 commits into from Apr 22, 2018
Merged

Mono: add vulnerabilities #39344

merged 2 commits into from Apr 22, 2018

Conversation

matthewbauer
Copy link
Member

@matthewbauer matthewbauer commented Apr 22, 2018 •
edited

Motivation for this change

See #39282 for discussion

/cc @viric @thoughtpolice @obadz @vrthra

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: mono

Partial log (click to expand)

these paths will be fetched (78.80 MiB download, 321.35 MiB unpacked):
  /nix/store/xsrnra6m2iq7y976nh772myncgn13j56-mono-5.8.0.108
copying path '/nix/store/xsrnra6m2iq7y976nh772myncgn13j56-mono-5.8.0.108' from 'https://cache.nixos.org'...
/nix/store/xsrnra6m2iq7y976nh772myncgn13j56-mono-5.8.0.108

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: mono

Partial log (click to expand)

these paths will be fetched (113.89 MiB download, 434.01 MiB unpacked):
  /nix/store/2l2ybwzmp016j3jkpn0mrwskf7wbqxvx-mono-5.8.0.108
copying path '/nix/store/2l2ybwzmp016j3jkpn0mrwskf7wbqxvx-mono-5.8.0.108' from 'https://cache.nixos.org'...
/nix/store/2l2ybwzmp016j3jkpn0mrwskf7wbqxvx-mono-5.8.0.108

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: mono

Partial log (click to expand)

make[5]: *** [build/rules.make:224: all-recursive] Error 1
make[4]: *** [Makefile:53: profile-do--basic--all] Error 2
make[3]: *** [Makefile:49: profiles-do--all] Error 2
make[2]: *** [Makefile:636: all-local] Error 2
make[2]: Leaving directory '/build/mono-5.8.0.108/runtime'
make[1]: *** [Makefile:549: all-recursive] Error 1
make[1]: Leaving directory '/build/mono-5.8.0.108'
make: *** [Makefile:479: all] Error 2
builder for '/nix/store/010lh76nz4w1lziyzyb61s2ixhcn729x-mono-5.8.0.108.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/010lh76nz4w1lziyzyb61s2ixhcn729x-mono-5.8.0.108.drv' failed

@Mic92
Copy link
Member

Mic92 commented Apr 22, 2018

see also #36711

@Mic92
Copy link
Member

Mic92 commented Apr 22, 2018

Updating mono will break some stuff unfortunately.

@matthewbauer
Copy link
Member Author

Ok dropped the last commit. Still want to put in knownVulnerabilities

@Mic92
Copy link
Member

Mic92 commented Apr 22, 2018

I also tried updating mono last weekend, but it is still wip:
Mic92@54d32e6

@matthewbauer matthewbauer changed the title Mono: add vulnerabilities, change version Mono: add vulnerabilities Apr 22, 2018
@Mic92
Copy link
Member

Mic92 commented Apr 22, 2018 •
edited

[EDIT] In future we should avoid adding so many different versions of mono.

@matthewbauer matthewbauer merged commit 6ec7c39 into NixOS:master Apr 22, 2018
@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: mono

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: mono

Partial log (click to expand)

~/.config/nixpkgs/config.nix, like so:

     {
       permittedInsecurePackages = [
         "mono-4.0.4.1"
       ];
     }

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: mono

Partial log (click to expand)

~/.config/nixpkgs/config.nix, like so:

     {
       permittedInsecurePackages = [
         "mono-4.0.4.1"
       ];
     }

@ShalokShalom
Copy link

ShalokShalom commented Apr 25, 2018 •
edited

@Mic92 You mean avoid?

@Mic92
Copy link
Member

Mic92 commented Apr 25, 2018

@ShalokShalom yes. updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrthra vrthra Awaiting requested review from vrthra

@orivej orivej Awaiting requested review from orivej

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matthewbauer @GrahamcOfBorg @Mic92 @ShalokShalom