Fixes cargo-edit #39348

Gerschtli · 2018-04-22T23:00:24Z

Motivation for this change

cargo-edit was tagged as broken. This PR allows build again.
Uses carnix instead of buildRustPackage.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

Gerschtli · 2018-05-16T22:51:28Z

@GrahamcOfBorg build cargo-edit

matthewbauer · 2018-05-17T02:08:37Z

@GrahamcOfBorg build cargo-edit

GrahamcOfBorg · 2018-05-17T02:12:50Z

Failure on x86_64-darwin (full log)

Attempted: cargo-edit

Partial log (click to expand)

  |
  = note: "/nix/store/8b0gj3bmcy5bh1zcnhn0146199b3m5kb-clang-wrapper-5.0.1/bin/cc" "-m64" "-L" "/nix/store/lq1fkripn218mw40k6ryx4q9pbi2qn3j-rustc-1.25.0/lib/rustlib/x86_64-apple-darwin/lib" "target/bin/cargo_add.cargo_add0.rcgu.o" "-o" "target/bin/cargo_add" "target/bin/cargo_add.crate.allocator.rcgu.o" "-Wl,-dead_strip" "-nodefaultlibs" "-L" "target/deps" "-L" "/nix/store/lq1fkripn218mw40k6ryx4q9pbi2qn3j-rustc-1.25.0/lib/rustlib/x86_64-apple-darwin/lib" "-framework" "CoreFoundation" "-framework" "Security" "/private/tmp/nix-build-cargo-edit-0.2.0.drv-0/source/target/lib/libcargo_edit-f8705a971a.rlib" "/nix/store/c0rp3hynzir2h1pjhh8dic108nwb60yk-rust_quick-error-1.2.0/lib/libquick_error-51269fa6f5.rlib" "/nix/store/6gv6vw2hdn2j61bm1glql9ixzim18vbq-rust_semver-0.7.0/lib/libsemver-fc5239a5b9.rlib" "/nix/store/rsl15wb4v6s86adxsprx3iqgwy9yd9xv-rust_semver-parser-0.7.0/lib/libsemver_parser-a833eac115.rlib" "/nix/store/y50rpzkq1j8cjdr7ki5d2d52216721nz-rust_toml-0.4.2/lib/libtoml-3c4badb035.rlib" "/nix/store/3wvlbcp6bjlpphrhknzmafas5idv4mbw-rust_docopt-0.8.1/lib/libdocopt-12b70277bd.rlib" "/nix/store/7avjarmpf8q0md9j3mjxvrdi3n2f9lsv-rust_strsim-0.6.0/lib/libstrsim-110454a718.rlib" "/nix/store/qhjy9v692awlpz40jn4krx1q1x2yl90f-rust_regex-0.2.2/lib/libregex-bfdb2fdb8b.rlib" "/nix/store/badjvcldp22xh5dxy7shz82vah49scim-rust_utf8-ranges-1.0.0/lib/libutf8_ranges-8c3ad0a891.rlib" "/nix/store/1i6sa1r66zashcsy4rxxv9pykmmccx14-rust_regex-syntax-0.4.1/lib/libregex_syntax-1c690ce83b.rlib" "/nix/store/d76rcva51h7yqpai300vh7ijsmfws18s-rust_thread_local-0.3.4/lib/libthread_local-5115704cde.rlib" "/nix/store/1076piwd4qglxhz1yz9fraaij51922bx-rust_unreachable-1.0.0/lib/libunreachable-57900dbc82.rlib" "/nix/store/c4j4rcrrpm6zlldvb5kahjhihx43ajal-rust_void-1.0.2/lib/libvoid-f243064ce9.rlib" "/nix/store/8bpkfqv09jmnlmf71wr87krwc2qvqvqa-rust_aho-corasick-0.6.3/lib/libaho_corasick-d2060410fd.rlib" "/nix/store/nblhs0f7v7gn5yb35bhnzyvhgvp81q0i-rust_memchr-1.0.1/lib/libmemchr-3cd16e4c48.rlib" "/nix/store/0lfvz7kbgfklyx47x8rjd2b7vw02b8bp-rust_lazy_static-0.2.8/lib/liblazy_static-9fa4075c51.rlib" "/nix/store/dryafqp04rmhz8sprhfxyk0c5zs5rlif-rust_reqwest-0.7.1/lib/libreqwest-7e2274c82e.rlib" "/nix/store/6jglh1d30ppyb2glmrw21l1svz4bx705-rust_serde_urlencoded-0.5.1/lib/libserde_urlencoded-3e4b953015.rlib" "/nix/store/g2yzmrndlpl5l7xi8bzkp32a6bfrvyri-rust_url-1.5.1/lib/liburl-f1bffd99fd.rlib" "/nix/store/pwny3apv5vdhfsnj1vc3kmal47mmj1v7-rust_idna-0.1.4/lib/libidna-01b52bbec3.rlib" "/nix/store/p21anspndkxxckb75zb8kw0g0yl0qjwm-rust_unicode-normalization-0.1.5/lib/libunicode_normalization-e15e67bed9.rlib" "/nix/store/f7va54byx9bzzbx7rnl4yc8kmb53by9l-rust_unicode-bidi-0.3.4/lib/libunicode_bidi-6046bcca92.rlib" "/nix/store/95yrvpxbsiflg5kh3abi58jmxrckh3g6-rust_matches-0.1.6/lib/libmatches-f9aee7205d.rlib" "/nix/store/0p50gjdjlhiv6q5dpmfqd9sn03szs62p-rust_serde_json-1.0.2/lib/libserde_json-044726b45c.rlib" "/nix/store/wi36lmwdwb4ncb3nnp2p7cjq609y72wp-rust_dtoa-0.4.1/lib/libdtoa-41eec6dd7f.rlib" "/nix/store/mb2q5mmldmv3938kff04f0ailkmbafjh-rust_itoa-0.3.1/lib/libitoa-3068bddff0.rlib" "/nix/store/yy9mxsxdk0sbdz5hf62aq1xv14yl2wqw-rust_num-traits-0.1.40/lib/libnum_traits-1815e8b884.rlib" "/nix/store/d29z285byrc96lc11w2m6s4hk9xsrzk5-rust_serde-1.0.10/lib/libserde-543e46ed03.rlib" "/nix/store/kj6ygd37y0zxxa337g3y67l211jccfkg-rust_libflate-0.1.10/lib/liblibflate-0816a5655c.rlib" "/nix/store/51pxzca0jmyn7klw85v8bgv96kw38py8-rust_adler32-1.0.0/lib/libadler32-053307c4f1.rlib" "/nix/store/4h8vans3ffz4jxl4ash152vp53c5pw3v-rust_hyper-tls-0.1.2/lib/libhyper_tls-ae77dce861.rlib" "/nix/store/11jm2l9qgdk7k01dp6yy7g2w1fchgpk7-rust_tokio-tls-0.1.3/lib/libtokio_tls-01249d0a3d.rlib" "/nix/store/z2nhimlqbdy4w66n527ca7fq96nc2mn9-rust_native-tls-0.1.4/lib/libnative_tls-7386820ec9.rlib" "/nix/store/jsg485nqb3jl8fbd6wi7nypyb6zml45c-rust_tempdir-0.3.5/lib/libtempdir-d364886b44.rlib" "/nix/store/343wlynmrbi6xn3973cp63a6l4547x5v-rust_security-framework-0.1.14/lib/libsecurity_framework-3aae69debe.rlib" "/nix/store/8lh68zzx00hdsr4jyfykqr6f3kqmmvc1-rust_core-foundation-0.2.3/lib/libcore_foundation-eb24d46baf.rlib" "/nix/store/437qhnj55zp357fisdw4df8vmx42471i-rust_security-framework-sys-0.1.14/lib/libsecurity_framework_sys-d5617f4d76.rlib" "/nix/store/322v41j930j8j6f2nm8jppn06gkccn67-rust_core-foundation-sys-0.2.3/lib/libcore_foundation_sys-269fa30713.rlib" "/nix/store/1qk93s4siyd3hk7bshw0n69pvy107b64-rust_hyper-0.11.1/lib/libhyper-c967aeddf8.rlib" "/nix/store/13yyv3ybq5b9b2wfdyc3cy2bhsjbn413-rust_tokio-proto-0.1.1/lib/libtokio_proto-e52ea5051b.rlib" "/nix/store/677zi7pmwh0dkh52gm5f417qr2ldzkwy-rust_tokio-service-0.1.0/lib/libtokio_service-2e70dabbf1.rlib" "/nix/store/c5psdvp0prsga7zgi47cqz2jdi5n28bj-rust_take-0.1.0/lib/libtake-43a9abd2c1.rlib" "/nix/store/rg9a7y8wsjvp24dqj0fn0md5ik54d229-rust_smallvec-0.2.1/lib/libsmallvec-fd4ac10da9.rlib" "/nix/store/sljdm0dma8lgmmpk3b67812b0x4nhmh8-rust_rand-0.3.15/lib/librand-f583bf0fb4.rlib" "/nix/store/qx2a9cdhhbkrfra3fkx2m729yvhdskvv-rust_tokio-core-0.1.8/lib/libtokio_core-c3d6350fdd.rlib" "/nix/store/pgxj9wb6fqn6p7sc7x8xiqhhfj7wpa0x-rust_scoped-tls-0.1.0/lib/libscoped_tls-df274e8bcb.rlib" "/nix/store/nrcr72ag6b8b9wrb27g4p7cncb3lsazn-rust_tokio-io-0.1.2/lib/libtokio_io-a9975978f1.rlib" "/nix/store/j9315b3labrda9h184ajdxns9wf8s1fl-rust_mio-0.6.9/lib/libmio-064c22ba30.rlib" "/nix/store/g6nm08piqw4f7fmlsc08qfgxxlahbxaz-rust_slab-0.3.0/lib/libslab-aea628af9f.rlib" "/nix/store/ncgckdcw3bjn7r505zhjyckpa7shz8vq-rust_net2-0.2.30/lib/libnet2-0d85fe6323.rlib" "/nix/store/4wd84qd35ij8fzc4pps4w4692zdkhkrq-rust_cfg-if-0.1.2/lib/libcfg_if-b704d92238.rlib" "/nix/store/xw6rf31gxjlx60xnyy0vs4wpa6d6fz8b-rust_lazycell-0.4.0/lib/liblazycell-be1ea3ee60.rlib" "/nix/store/jiixkpkrbjf8k4w0b9z8kq1bbrydwndf-rust_time-0.1.38/lib/libtime-692114bd99.rlib" "/nix/store/cpz1w5izxjfjag9zq8ghy80n1ygm3cd0-rust_percent-encoding-1.0.0/lib/libpercent_encoding-2c0279000f.rlib" "/nix/store/zc9zg07v8c2dxs7345i4gsgz67rrlxcg-rust_mime-0.3.2/lib/libmime-9ba05d3fff.rlib" "/nix/store/rzn2m0k6plmw9dxlg90hc9jgi7xhzqfv-rust_unicase-2.0.0/lib/libunicase-02f248d9bb.rlib" "/nix/store/3vlajfkxb41wn3v78fhkdzhhkijqw4sa-rust_log-0.3.8/lib/liblog-bf1d0b7fdf.rlib" "/nix/store/wvihsz4iqya28vbzh4p9hlwhsssc35ri-rust_language-tags-0.2.2/lib/liblanguage_tags-1a45ccdd01.rlib" "/nix/store/infhq3l3c0da59w7k79psqffcmm02ghw-rust_httparse-1.2.3/lib/libhttparse-e1f2e7ec66.rlib" "/nix/store/gmsmzf4p7ml790drycd22xyd3kfi1k7f-rust_futures-cpupool-0.1.5/lib/libfutures_cpupool-36acca67b0.rlib" "/nix/store/qpyzymh9hjqk5ygzd1adm76zxd5f9z2k-rust_num_cpus-1.6.2/lib/libnum_cpus-da53713fd8.rlib" "/nix/store/yxriwsn0wy0dypcn0ay63ijcr8an7r0j-rust_base64-0.6.0/lib/libbase64-74633fb67f.rlib" "/nix/store/ml1p11v75kdwrrk78384ind785nxxn9h-rust_safemem-0.2.0/lib/libsafemem-7e73cb6443.rlib" "/nix/store/lxchiynzp3s0bv6v9akdfk9n8zhyhpmh-rust_futures-0.1.14/lib/libfutures-41b4ac650c.rlib" "/nix/store/d8xb2hwa296szxqr7asbv7mfsz135vx8-rust_bytes-0.4.4/lib/libbytes-a07aff3fba.rlib" "/nix/store/kqk1djbcdk7549ys5c70y1blij45a4ay-rust_iovec-0.1.0/lib/libiovec-ad5d36eb58.rlib" "/nix/store/v6i7zq4zskwp9pssrgsmjgb9f281fb9h-rust_libc-0.2.26/lib/liblibc-fc84d17830.rlib" "/nix/store/d93j4z7hkhw7rnngybzfhanndrx3vkrc-rust_byteorder-1.1.0/lib/libbyteorder-33149ee554.rlib" "/nix/store/lq1fkripn218mw40k6ryx4q9pbi2qn3j-rustc-1.25.0/lib/rustlib/x86_64-apple-darwin/lib/libstd-99517fd8418575af.rlib" "/nix/store/lq1fkripn218mw40k6ryx4q9pbi2qn3j-rustc-1.25.0/lib/rustlib/x86_64-apple-darwin/lib/libpanic_unwind-735653faa89a3d8f.rlib" "/nix/store/lq1fkripn218mw40k6ryx4q9pbi2qn3j-rustc-1.25.0/lib/rustlib/x86_64-apple-darwin/lib/liballoc_jemalloc-1660f8dbf2c9cc18.rlib" "/nix/store/lq1fkripn218mw40k6ryx4q9pbi2qn3j-rustc-1.25.0/lib/rustlib/x86_64-apple-darwin/lib/libunwind-eb0119466dc7dd45.rlib" "/nix/store/lq1fkripn218mw40k6ryx4q9pbi2qn3j-rustc-1.25.0/lib/rustlib/x86_64-apple-darwin/lib/liballoc_system-c5d62d76b40af347.rlib" "/nix/store/lq1fkripn218mw40k6ryx4q9pbi2qn3j-rustc-1.25.0/lib/rustlib/x86_64-apple-darwin/lib/liblibc-83516d828d0ef89a.rlib" "/nix/store/lq1fkripn218mw40k6ryx4q9pbi2qn3j-rustc-1.25.0/lib/rustlib/x86_64-apple-darwin/lib/liballoc-1803f97b225509de.rlib" "/nix/store/lq1fkripn218mw40k6ryx4q9pbi2qn3j-rustc-1.25.0/lib/rustlib/x86_64-apple-darwin/lib/libstd_unicode-e13d4f6802109bfb.rlib" "/nix/store/lq1fkripn218mw40k6ryx4q9pbi2qn3j-rustc-1.25.0/lib/rustlib/x86_64-apple-darwin/lib/libcore-912ae50db7c2aa0f.rlib" "/nix/store/lq1fkripn218mw40k6ryx4q9pbi2qn3j-rustc-1.25.0/lib/rustlib/x86_64-apple-darwin/lib/libcompiler_builtins-b2d2cff1928b4d96.rlib" "-framework" "CoreFoundation" "-framework" "Security" "-framework" "CoreFoundation" "-framework" "Security" "-framework" "CoreFoundation" "-framework" "Security" "-framework" "CoreFoundation" "-framework" "Security" "-framework" "CoreFoundation" "-framework" "Security" "-framework" "CoreFoundation" "-framework" "Security" "-framework" "CoreFoundation" "-framework" "CoreFoundation" "-l" "System" "-l" "resolv" "-l" "pthread" "-l" "c" "-l" "m"
  = note: ld: framework not found Security
          clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)


error: aborting due to previous error

builder for '/nix/store/z4myd2l357vs7cbnkfqz7c17lqxfbq34-cargo-edit-0.2.0.drv' failed with exit code 101
error: build of '/nix/store/z4myd2l357vs7cbnkfqz7c17lqxfbq34-cargo-edit-0.2.0.drv' failed

GrahamcOfBorg · 2018-05-17T02:14:47Z

Success on x86_64-linux (full log)

Attempted: cargo-edit

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/qc60bhz69zm5vjr4kjl37inzfmcy25np-cargo-edit-0.2.0
shrinking /nix/store/qc60bhz69zm5vjr4kjl37inzfmcy25np-cargo-edit-0.2.0/bin/cargo-upgrade
shrinking /nix/store/qc60bhz69zm5vjr4kjl37inzfmcy25np-cargo-edit-0.2.0/bin/cargo-rm
shrinking /nix/store/qc60bhz69zm5vjr4kjl37inzfmcy25np-cargo-edit-0.2.0/bin/cargo-add
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/qc60bhz69zm5vjr4kjl37inzfmcy25np-cargo-edit-0.2.0/lib  /nix/store/qc60bhz69zm5vjr4kjl37inzfmcy25np-cargo-edit-0.2.0/bin
patching script interpreter paths in /nix/store/qc60bhz69zm5vjr4kjl37inzfmcy25np-cargo-edit-0.2.0
checking for references to /build in /nix/store/qc60bhz69zm5vjr4kjl37inzfmcy25np-cargo-edit-0.2.0...
/nix/store/qc60bhz69zm5vjr4kjl37inzfmcy25np-cargo-edit-0.2.0

GrahamcOfBorg · 2018-05-17T03:09:44Z

Failure on aarch64-linux (full log)

Attempted: cargo-edit

Partial log (click to expand)

cannot build derivation '/nix/store/b86ahc9kn0pawdlipasypiakh3hqaimf-rust_serde_urlencoded-0.5.1.drv': 10 dependencies couldn't be built
cannot build derivation '/nix/store/fvikljysrja6m498ig108gcc9j4nykaf-rust_tokio-core-0.1.8.drv': 14 dependencies couldn't be built
cannot build derivation '/nix/store/0hcqsnq5riakgjk24kz2mdyl3dy2swaj-rust_docopt-0.8.1.drv': 19 dependencies couldn't be built
cannot build derivation '/nix/store/0rzxi5glx14758dyv09v19027kbszjbp-rust_tokio-proto-0.1.1.drv': 19 dependencies couldn't be built
cannot build derivation '/nix/store/7cb1jyi0farwynmw59bbj1g3nljvb96m-rust_tokio-tls-0.1.3.drv': 21 dependencies couldn't be built
cannot build derivation '/nix/store/37rsgk9rbgfn7kiz6bk5q92yll1nggf5-rust_hyper-0.11.1.drv': 30 dependencies couldn't be built
cannot build derivation '/nix/store/6n2d22qwd6gcqsqq6wlf1d0b7aw6r187-rust_hyper-tls-0.1.2.drv': 38 dependencies couldn't be built
cannot build derivation '/nix/store/4sbh09x6dn4wbk09y5hgisfz95mkxym3-rust_reqwest-0.7.1.drv': 52 dependencies couldn't be built
cannot build derivation '/nix/store/6ywp8rpplbdj6rkmadkqw5ljkdywq9yp-cargo-edit-0.2.0.drv': 75 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/6ywp8rpplbdj6rkmadkqw5ljkdywq9yp-cargo-edit-0.2.0.drv' failed

Gerschtli · 2018-05-17T16:02:07Z

@matthewbauer can you help me with fixing these builds?

matthewbauer · 2018-05-17T19:26:09Z

I'm going to need to let someone else review this. I don't know enough about carnix to really review it.

@GrahamcOfBorg build cargo-edit

GrahamcOfBorg · 2018-05-17T19:42:45Z

Success on x86_64-linux (full log)

Attempted: cargo-edit

Partial log (click to expand)

/nix/store/qc60bhz69zm5vjr4kjl37inzfmcy25np-cargo-edit-0.2.0

GrahamcOfBorg · 2018-05-17T19:44:19Z

Failure on x86_64-darwin (full log)

Attempted: cargo-edit

Partial log (click to expand)

  |
  = note: "/nix/store/8b0gj3bmcy5bh1zcnhn0146199b3m5kb-clang-wrapper-5.0.1/bin/cc" "-m64" "-L" "/nix/store/lq1fkripn218mw40k6ryx4q9pbi2qn3j-rustc-1.25.0/lib/rustlib/x86_64-apple-darwin/lib" "target/bin/cargo_add.cargo_add0.rcgu.o" "-o" "target/bin/cargo_add" "target/bin/cargo_add.crate.allocator.rcgu.o" "-Wl,-dead_strip" "-nodefaultlibs" "-L" "target/deps" "-L" "/nix/store/lq1fkripn218mw40k6ryx4q9pbi2qn3j-rustc-1.25.0/lib/rustlib/x86_64-apple-darwin/lib" "-framework" "CoreFoundation" "-framework" "Security" "/private/tmp/nix-build-cargo-edit-0.2.0.drv-0/source/target/lib/libcargo_edit-f8705a971a.rlib" "/nix/store/c0rp3hynzir2h1pjhh8dic108nwb60yk-rust_quick-error-1.2.0/lib/libquick_error-51269fa6f5.rlib" "/nix/store/6gv6vw2hdn2j61bm1glql9ixzim18vbq-rust_semver-0.7.0/lib/libsemver-fc5239a5b9.rlib" "/nix/store/rsl15wb4v6s86adxsprx3iqgwy9yd9xv-rust_semver-parser-0.7.0/lib/libsemver_parser-a833eac115.rlib" "/nix/store/y50rpzkq1j8cjdr7ki5d2d52216721nz-rust_toml-0.4.2/lib/libtoml-3c4badb035.rlib" "/nix/store/3wvlbcp6bjlpphrhknzmafas5idv4mbw-rust_docopt-0.8.1/lib/libdocopt-12b70277bd.rlib" "/nix/store/7avjarmpf8q0md9j3mjxvrdi3n2f9lsv-rust_strsim-0.6.0/lib/libstrsim-110454a718.rlib" "/nix/store/qhjy9v692awlpz40jn4krx1q1x2yl90f-rust_regex-0.2.2/lib/libregex-bfdb2fdb8b.rlib" "/nix/store/badjvcldp22xh5dxy7shz82vah49scim-rust_utf8-ranges-1.0.0/lib/libutf8_ranges-8c3ad0a891.rlib" "/nix/store/1i6sa1r66zashcsy4rxxv9pykmmccx14-rust_regex-syntax-0.4.1/lib/libregex_syntax-1c690ce83b.rlib" "/nix/store/d76rcva51h7yqpai300vh7ijsmfws18s-rust_thread_local-0.3.4/lib/libthread_local-5115704cde.rlib" "/nix/store/1076piwd4qglxhz1yz9fraaij51922bx-rust_unreachable-1.0.0/lib/libunreachable-57900dbc82.rlib" "/nix/store/c4j4rcrrpm6zlldvb5kahjhihx43ajal-rust_void-1.0.2/lib/libvoid-f243064ce9.rlib" "/nix/store/8bpkfqv09jmnlmf71wr87krwc2qvqvqa-rust_aho-corasick-0.6.3/lib/libaho_corasick-d2060410fd.rlib" "/nix/store/nblhs0f7v7gn5yb35bhnzyvhgvp81q0i-rust_memchr-1.0.1/lib/libmemchr-3cd16e4c48.rlib" "/nix/store/0lfvz7kbgfklyx47x8rjd2b7vw02b8bp-rust_lazy_static-0.2.8/lib/liblazy_static-9fa4075c51.rlib" "/nix/store/2pf6v4zjjrinhrqfq57fah4n6i42xxzj-rust_reqwest-0.7.1/lib/libreqwest-7e2274c82e.rlib" "/nix/store/6jglh1d30ppyb2glmrw21l1svz4bx705-rust_serde_urlencoded-0.5.1/lib/libserde_urlencoded-3e4b953015.rlib" "/nix/store/g2yzmrndlpl5l7xi8bzkp32a6bfrvyri-rust_url-1.5.1/lib/liburl-f1bffd99fd.rlib" "/nix/store/pwny3apv5vdhfsnj1vc3kmal47mmj1v7-rust_idna-0.1.4/lib/libidna-01b52bbec3.rlib" "/nix/store/p21anspndkxxckb75zb8kw0g0yl0qjwm-rust_unicode-normalization-0.1.5/lib/libunicode_normalization-e15e67bed9.rlib" "/nix/store/f7va54byx9bzzbx7rnl4yc8kmb53by9l-rust_unicode-bidi-0.3.4/lib/libunicode_bidi-6046bcca92.rlib" "/nix/store/95yrvpxbsiflg5kh3abi58jmxrckh3g6-rust_matches-0.1.6/lib/libmatches-f9aee7205d.rlib" "/nix/store/0p50gjdjlhiv6q5dpmfqd9sn03szs62p-rust_serde_json-1.0.2/lib/libserde_json-044726b45c.rlib" "/nix/store/wi36lmwdwb4ncb3nnp2p7cjq609y72wp-rust_dtoa-0.4.1/lib/libdtoa-41eec6dd7f.rlib" "/nix/store/mb2q5mmldmv3938kff04f0ailkmbafjh-rust_itoa-0.3.1/lib/libitoa-3068bddff0.rlib" "/nix/store/yy9mxsxdk0sbdz5hf62aq1xv14yl2wqw-rust_num-traits-0.1.40/lib/libnum_traits-1815e8b884.rlib" "/nix/store/d29z285byrc96lc11w2m6s4hk9xsrzk5-rust_serde-1.0.10/lib/libserde-543e46ed03.rlib" "/nix/store/kj6ygd37y0zxxa337g3y67l211jccfkg-rust_libflate-0.1.10/lib/liblibflate-0816a5655c.rlib" "/nix/store/51pxzca0jmyn7klw85v8bgv96kw38py8-rust_adler32-1.0.0/lib/libadler32-053307c4f1.rlib" "/nix/store/ls439i4w0x7ksrxyhbxr6mwv2plgn3gn-rust_hyper-tls-0.1.2/lib/libhyper_tls-ae77dce861.rlib" "/nix/store/npl0dpy502y0kby9sqx342h8n3gjy1r3-rust_tokio-tls-0.1.3/lib/libtokio_tls-01249d0a3d.rlib" "/nix/store/4jvbszbv08s5lgfykpndy5nmgbw8cnkh-rust_native-tls-0.1.4/lib/libnative_tls-7386820ec9.rlib" "/nix/store/jsg485nqb3jl8fbd6wi7nypyb6zml45c-rust_tempdir-0.3.5/lib/libtempdir-d364886b44.rlib" "/nix/store/y9w91wvw2nksndkp885gmna6nf1lzq97-rust_security-framework-0.1.14/lib/libsecurity_framework-3aae69debe.rlib" "/nix/store/8lh68zzx00hdsr4jyfykqr6f3kqmmvc1-rust_core-foundation-0.2.3/lib/libcore_foundation-eb24d46baf.rlib" "/nix/store/s1f2x072c0qwd6vw5k064jk6mz65cvhm-rust_security-framework-sys-0.1.14/lib/libsecurity_framework_sys-d5617f4d76.rlib" "/nix/store/322v41j930j8j6f2nm8jppn06gkccn67-rust_core-foundation-sys-0.2.3/lib/libcore_foundation_sys-269fa30713.rlib" "/nix/store/1qk93s4siyd3hk7bshw0n69pvy107b64-rust_hyper-0.11.1/lib/libhyper-c967aeddf8.rlib" "/nix/store/13yyv3ybq5b9b2wfdyc3cy2bhsjbn413-rust_tokio-proto-0.1.1/lib/libtokio_proto-e52ea5051b.rlib" "/nix/store/677zi7pmwh0dkh52gm5f417qr2ldzkwy-rust_tokio-service-0.1.0/lib/libtokio_service-2e70dabbf1.rlib" "/nix/store/c5psdvp0prsga7zgi47cqz2jdi5n28bj-rust_take-0.1.0/lib/libtake-43a9abd2c1.rlib" "/nix/store/rg9a7y8wsjvp24dqj0fn0md5ik54d229-rust_smallvec-0.2.1/lib/libsmallvec-fd4ac10da9.rlib" "/nix/store/sljdm0dma8lgmmpk3b67812b0x4nhmh8-rust_rand-0.3.15/lib/librand-f583bf0fb4.rlib" "/nix/store/qx2a9cdhhbkrfra3fkx2m729yvhdskvv-rust_tokio-core-0.1.8/lib/libtokio_core-c3d6350fdd.rlib" "/nix/store/pgxj9wb6fqn6p7sc7x8xiqhhfj7wpa0x-rust_scoped-tls-0.1.0/lib/libscoped_tls-df274e8bcb.rlib" "/nix/store/nrcr72ag6b8b9wrb27g4p7cncb3lsazn-rust_tokio-io-0.1.2/lib/libtokio_io-a9975978f1.rlib" "/nix/store/j9315b3labrda9h184ajdxns9wf8s1fl-rust_mio-0.6.9/lib/libmio-064c22ba30.rlib" "/nix/store/g6nm08piqw4f7fmlsc08qfgxxlahbxaz-rust_slab-0.3.0/lib/libslab-aea628af9f.rlib" "/nix/store/ncgckdcw3bjn7r505zhjyckpa7shz8vq-rust_net2-0.2.30/lib/libnet2-0d85fe6323.rlib" "/nix/store/4wd84qd35ij8fzc4pps4w4692zdkhkrq-rust_cfg-if-0.1.2/lib/libcfg_if-b704d92238.rlib" "/nix/store/xw6rf31gxjlx60xnyy0vs4wpa6d6fz8b-rust_lazycell-0.4.0/lib/liblazycell-be1ea3ee60.rlib" "/nix/store/jiixkpkrbjf8k4w0b9z8kq1bbrydwndf-rust_time-0.1.38/lib/libtime-692114bd99.rlib" "/nix/store/cpz1w5izxjfjag9zq8ghy80n1ygm3cd0-rust_percent-encoding-1.0.0/lib/libpercent_encoding-2c0279000f.rlib" "/nix/store/zc9zg07v8c2dxs7345i4gsgz67rrlxcg-rust_mime-0.3.2/lib/libmime-9ba05d3fff.rlib" "/nix/store/rzn2m0k6plmw9dxlg90hc9jgi7xhzqfv-rust_unicase-2.0.0/lib/libunicase-02f248d9bb.rlib" "/nix/store/3vlajfkxb41wn3v78fhkdzhhkijqw4sa-rust_log-0.3.8/lib/liblog-bf1d0b7fdf.rlib" "/nix/store/wvihsz4iqya28vbzh4p9hlwhsssc35ri-rust_language-tags-0.2.2/lib/liblanguage_tags-1a45ccdd01.rlib" "/nix/store/infhq3l3c0da59w7k79psqffcmm02ghw-rust_httparse-1.2.3/lib/libhttparse-e1f2e7ec66.rlib" "/nix/store/gmsmzf4p7ml790drycd22xyd3kfi1k7f-rust_futures-cpupool-0.1.5/lib/libfutures_cpupool-36acca67b0.rlib" "/nix/store/qpyzymh9hjqk5ygzd1adm76zxd5f9z2k-rust_num_cpus-1.6.2/lib/libnum_cpus-da53713fd8.rlib" "/nix/store/yxriwsn0wy0dypcn0ay63ijcr8an7r0j-rust_base64-0.6.0/lib/libbase64-74633fb67f.rlib" "/nix/store/ml1p11v75kdwrrk78384ind785nxxn9h-rust_safemem-0.2.0/lib/libsafemem-7e73cb6443.rlib" "/nix/store/lxchiynzp3s0bv6v9akdfk9n8zhyhpmh-rust_futures-0.1.14/lib/libfutures-41b4ac650c.rlib" "/nix/store/d8xb2hwa296szxqr7asbv7mfsz135vx8-rust_bytes-0.4.4/lib/libbytes-a07aff3fba.rlib" "/nix/store/kqk1djbcdk7549ys5c70y1blij45a4ay-rust_iovec-0.1.0/lib/libiovec-ad5d36eb58.rlib" "/nix/store/v6i7zq4zskwp9pssrgsmjgb9f281fb9h-rust_libc-0.2.26/lib/liblibc-fc84d17830.rlib" "/nix/store/d93j4z7hkhw7rnngybzfhanndrx3vkrc-rust_byteorder-1.1.0/lib/libbyteorder-33149ee554.rlib" "/nix/store/lq1fkripn218mw40k6ryx4q9pbi2qn3j-rustc-1.25.0/lib/rustlib/x86_64-apple-darwin/lib/libstd-99517fd8418575af.rlib" "/nix/store/lq1fkripn218mw40k6ryx4q9pbi2qn3j-rustc-1.25.0/lib/rustlib/x86_64-apple-darwin/lib/libpanic_unwind-735653faa89a3d8f.rlib" "/nix/store/lq1fkripn218mw40k6ryx4q9pbi2qn3j-rustc-1.25.0/lib/rustlib/x86_64-apple-darwin/lib/liballoc_jemalloc-1660f8dbf2c9cc18.rlib" "/nix/store/lq1fkripn218mw40k6ryx4q9pbi2qn3j-rustc-1.25.0/lib/rustlib/x86_64-apple-darwin/lib/libunwind-eb0119466dc7dd45.rlib" "/nix/store/lq1fkripn218mw40k6ryx4q9pbi2qn3j-rustc-1.25.0/lib/rustlib/x86_64-apple-darwin/lib/liballoc_system-c5d62d76b40af347.rlib" "/nix/store/lq1fkripn218mw40k6ryx4q9pbi2qn3j-rustc-1.25.0/lib/rustlib/x86_64-apple-darwin/lib/liblibc-83516d828d0ef89a.rlib" "/nix/store/lq1fkripn218mw40k6ryx4q9pbi2qn3j-rustc-1.25.0/lib/rustlib/x86_64-apple-darwin/lib/liballoc-1803f97b225509de.rlib" "/nix/store/lq1fkripn218mw40k6ryx4q9pbi2qn3j-rustc-1.25.0/lib/rustlib/x86_64-apple-darwin/lib/libstd_unicode-e13d4f6802109bfb.rlib" "/nix/store/lq1fkripn218mw40k6ryx4q9pbi2qn3j-rustc-1.25.0/lib/rustlib/x86_64-apple-darwin/lib/libcore-912ae50db7c2aa0f.rlib" "/nix/store/lq1fkripn218mw40k6ryx4q9pbi2qn3j-rustc-1.25.0/lib/rustlib/x86_64-apple-darwin/lib/libcompiler_builtins-b2d2cff1928b4d96.rlib" "-framework" "CoreFoundation" "-framework" "Security" "-framework" "CoreFoundation" "-framework" "Security" "-framework" "CoreFoundation" "-framework" "Security" "-framework" "CoreFoundation" "-framework" "Security" "-framework" "CoreFoundation" "-framework" "Security" "-framework" "CoreFoundation" "-framework" "Security" "-framework" "CoreFoundation" "-framework" "CoreFoundation" "-l" "System" "-l" "resolv" "-l" "pthread" "-l" "c" "-l" "m"
  = note: ld: framework not found Security
          clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)


error: aborting due to previous error

builder for '/nix/store/b1f5vp5k6imz6zhsczahz8pfjf75arsq-cargo-edit-0.2.0.drv' failed with exit code 101
error: build of '/nix/store/b1f5vp5k6imz6zhsczahz8pfjf75arsq-cargo-edit-0.2.0.drv' failed

GrahamcOfBorg · 2018-05-17T22:27:37Z

Failure on aarch64-linux (full log)

Attempted: cargo-edit

Partial log (click to expand)

cannot build derivation '/nix/store/b86ahc9kn0pawdlipasypiakh3hqaimf-rust_serde_urlencoded-0.5.1.drv': 10 dependencies couldn't be built
cannot build derivation '/nix/store/fvikljysrja6m498ig108gcc9j4nykaf-rust_tokio-core-0.1.8.drv': 14 dependencies couldn't be built
cannot build derivation '/nix/store/0hcqsnq5riakgjk24kz2mdyl3dy2swaj-rust_docopt-0.8.1.drv': 19 dependencies couldn't be built
cannot build derivation '/nix/store/0rzxi5glx14758dyv09v19027kbszjbp-rust_tokio-proto-0.1.1.drv': 19 dependencies couldn't be built
cannot build derivation '/nix/store/7cb1jyi0farwynmw59bbj1g3nljvb96m-rust_tokio-tls-0.1.3.drv': 21 dependencies couldn't be built
cannot build derivation '/nix/store/37rsgk9rbgfn7kiz6bk5q92yll1nggf5-rust_hyper-0.11.1.drv': 30 dependencies couldn't be built
cannot build derivation '/nix/store/6n2d22qwd6gcqsqq6wlf1d0b7aw6r187-rust_hyper-tls-0.1.2.drv': 38 dependencies couldn't be built
cannot build derivation '/nix/store/4sbh09x6dn4wbk09y5hgisfz95mkxym3-rust_reqwest-0.7.1.drv': 52 dependencies couldn't be built
cannot build derivation '/nix/store/6ywp8rpplbdj6rkmadkqw5ljkdywq9yp-cargo-edit-0.2.0.drv': 75 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/6ywp8rpplbdj6rkmadkqw5ljkdywq9yp-cargo-edit-0.2.0.drv' failed

Gerschtli · 2018-05-19T11:04:07Z

@P-E-Meunier do you have any idea? you seem very involved in carnix in nixpkgs

xeji · 2018-05-31T07:39:00Z

@GrahamcOfBorg build cargo-edit

GrahamcOfBorg · 2018-05-31T07:42:20Z

Success on x86_64-darwin (full log)

Attempted: cargo-edit

Partial log (click to expand)

Building cargo_rm (src/bin/rm/main.rs)
Running rustc --crate-name cargo_rm src/bin/rm/main.rs --crate-type bin -C opt-level=3 -C codegen-units=1 --cfg feature="default" --out-dir target/bin --emit=dep-info,link -L dependency=target/deps -l framework=CoreFoundation -l framework=Security --extern docopt=/nix/store/221ngg9d19ass7b8pqqwd671hwfdcjby-rust_docopt-0.8.1/lib/libdocopt-12b70277bd.rlib --extern pad=/nix/store/v7wdd0myc95ixg14x50f5l3y6dxv0gdk-rust_pad-0.1.4/lib/libpad-d0b9a032b1.rlib --extern quick_error=/nix/store/3mrsiyazkynxafp2vppyn03ac6r8xijl-rust_quick-error-1.2.0/lib/libquick_error-51269fa6f5.rlib --extern regex=/nix/store/24cvpjxb111a4j2lxvgi389x6mghvv68-rust_regex-0.2.2/lib/libregex-bfdb2fdb8b.rlib --extern reqwest=/nix/store/pmib8zdkb014k75fnq8kgi0pamfzqd72-rust_reqwest-0.7.1/lib/libreqwest-7e2274c82e.rlib --extern semver=/nix/store/p98wb5nhkzid0vqfjsc12h4v78xd3ys2-rust_semver-0.7.0/lib/libsemver-fc5239a5b9.rlib --extern serde=/nix/store/3d02alwpl5f93iij368clway95hlc079-rust_serde-1.0.10/lib/libserde-543e46ed03.rlib --extern serde_derive=/nix/store/x9s89rxv5ch03m7mk46p7d5cfvd422am-rust_serde_derive-1.0.10/lib/libserde_derive-81127ca55e.dylib --extern serde_json=/nix/store/hq1j5xz8x0sq3xn1dss1bnqrgmzn22nd-rust_serde_json-1.0.2/lib/libserde_json-044726b45c.rlib --extern toml=/nix/store/qqxc3687sqllvgwncfnrys60myy1g7f8-rust_toml-0.4.2/lib/libtoml-3c4badb035.rlib --extern cargo_edit=target/lib/libcargo_edit-f8705a971a.rlib --cap-lints allow -l framework=CoreFoundation -l framework=Security --color always
Building cargo_upgrade (src/bin/upgrade/main.rs)
Running rustc --crate-name cargo_upgrade src/bin/upgrade/main.rs --crate-type bin -C opt-level=3 -C codegen-units=1 --cfg feature="default" --out-dir target/bin --emit=dep-info,link -L dependency=target/deps -l framework=CoreFoundation -l framework=Security --extern docopt=/nix/store/221ngg9d19ass7b8pqqwd671hwfdcjby-rust_docopt-0.8.1/lib/libdocopt-12b70277bd.rlib --extern pad=/nix/store/v7wdd0myc95ixg14x50f5l3y6dxv0gdk-rust_pad-0.1.4/lib/libpad-d0b9a032b1.rlib --extern quick_error=/nix/store/3mrsiyazkynxafp2vppyn03ac6r8xijl-rust_quick-error-1.2.0/lib/libquick_error-51269fa6f5.rlib --extern regex=/nix/store/24cvpjxb111a4j2lxvgi389x6mghvv68-rust_regex-0.2.2/lib/libregex-bfdb2fdb8b.rlib --extern reqwest=/nix/store/pmib8zdkb014k75fnq8kgi0pamfzqd72-rust_reqwest-0.7.1/lib/libreqwest-7e2274c82e.rlib --extern semver=/nix/store/p98wb5nhkzid0vqfjsc12h4v78xd3ys2-rust_semver-0.7.0/lib/libsemver-fc5239a5b9.rlib --extern serde=/nix/store/3d02alwpl5f93iij368clway95hlc079-rust_serde-1.0.10/lib/libserde-543e46ed03.rlib --extern serde_derive=/nix/store/x9s89rxv5ch03m7mk46p7d5cfvd422am-rust_serde_derive-1.0.10/lib/libserde_derive-81127ca55e.dylib --extern serde_json=/nix/store/hq1j5xz8x0sq3xn1dss1bnqrgmzn22nd-rust_serde_json-1.0.2/lib/libserde_json-044726b45c.rlib --extern toml=/nix/store/qqxc3687sqllvgwncfnrys60myy1g7f8-rust_toml-0.4.2/lib/libtoml-3c4badb035.rlib --extern cargo_edit=target/lib/libcargo_edit-f8705a971a.rlib --cap-lints allow -l framework=CoreFoundation -l framework=Security --color always
installing
post-installation fixup
strip is /nix/store/r5mcn9vqq80v5pfqp45d7290cis7dwp4-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/70pvr3wisjlwxs6bmcsq255zbrx85ckf-cargo-edit-0.2.0/lib  /nix/store/70pvr3wisjlwxs6bmcsq255zbrx85ckf-cargo-edit-0.2.0/bin
patching script interpreter paths in /nix/store/70pvr3wisjlwxs6bmcsq255zbrx85ckf-cargo-edit-0.2.0
/nix/store/70pvr3wisjlwxs6bmcsq255zbrx85ckf-cargo-edit-0.2.0

GrahamcOfBorg · 2018-05-31T07:43:20Z

Success on x86_64-linux (full log)

Attempted: cargo-edit

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/rwizz2hx9sv43w6ndqc80s9q4wmz9gs0-cargo-edit-0.2.0
shrinking /nix/store/rwizz2hx9sv43w6ndqc80s9q4wmz9gs0-cargo-edit-0.2.0/bin/cargo-add
shrinking /nix/store/rwizz2hx9sv43w6ndqc80s9q4wmz9gs0-cargo-edit-0.2.0/bin/cargo-rm
shrinking /nix/store/rwizz2hx9sv43w6ndqc80s9q4wmz9gs0-cargo-edit-0.2.0/bin/cargo-upgrade
strip is /nix/store/92d2ifxcni4n3zx9s8wnkcjlvnx5ajlc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rwizz2hx9sv43w6ndqc80s9q4wmz9gs0-cargo-edit-0.2.0/lib  /nix/store/rwizz2hx9sv43w6ndqc80s9q4wmz9gs0-cargo-edit-0.2.0/bin
patching script interpreter paths in /nix/store/rwizz2hx9sv43w6ndqc80s9q4wmz9gs0-cargo-edit-0.2.0
checking for references to /build in /nix/store/rwizz2hx9sv43w6ndqc80s9q4wmz9gs0-cargo-edit-0.2.0...
/nix/store/rwizz2hx9sv43w6ndqc80s9q4wmz9gs0-cargo-edit-0.2.0

GrahamcOfBorg · 2018-05-31T09:01:55Z

Failure on aarch64-linux (full log)

Attempted: cargo-edit

Partial log (click to expand)

cannot build derivation '/nix/store/jf7mqp5slb29w9ddnzrcr9whzyl6ik24-rust_serde_urlencoded-0.5.1.drv': 10 dependencies couldn't be built
cannot build derivation '/nix/store/l97mfywfhmhkdz65n3ggyqh6v67via9a-rust_tokio-core-0.1.8.drv': 14 dependencies couldn't be built
cannot build derivation '/nix/store/98mr6rwlpm559lv016vnbkmyvnxdcn26-rust_docopt-0.8.1.drv': 19 dependencies couldn't be built
cannot build derivation '/nix/store/f3cgq83mp430rq3kxxsd9m6rxczlbvzh-rust_tokio-proto-0.1.1.drv': 19 dependencies couldn't be built
cannot build derivation '/nix/store/a1cfkzpf6cplisxad3601npravxa2gvn-rust_tokio-tls-0.1.3.drv': 21 dependencies couldn't be built
cannot build derivation '/nix/store/amnv2c7n114yrgm6i3bi8q0j5i7bnh23-rust_hyper-0.11.1.drv': 30 dependencies couldn't be built
cannot build derivation '/nix/store/dgls37015djddrqfvxdbzk586gzqhh42-rust_hyper-tls-0.1.2.drv': 38 dependencies couldn't be built
cannot build derivation '/nix/store/mjpihc6z1z5fmjiflf487myskx57rlmn-rust_reqwest-0.7.1.drv': 52 dependencies couldn't be built
cannot build derivation '/nix/store/2ris4xw92v81l9pikrxbiqla8if95iqz-cargo-edit-0.2.0.drv': 75 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/2ris4xw92v81l9pikrxbiqla8if95iqz-cargo-edit-0.2.0.drv' failed

Gerschtli · 2018-05-31T12:06:26Z

Seems good to me. Dont know what to do with the timeout on aarch64-linux

xeji · 2018-05-31T12:13:40Z

rustc builds for aarch64 typically time out on our ofborg machines, nothing to worry about. We'll see what happens on hydra.

matthewbauer · 2018-05-31T23:11:08Z

This is breaking the tarball:

https://hydra.nixos.org/build/75272616/nixlog/1

xeji · 2018-05-31T23:58:48Z

fixed in 0046d42

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Apr 22, 2018

Gerschtli force-pushed the fix/cargo-edit branch from 2c403ba to aee4ef8 Compare May 19, 2018 13:03

GrahamcOfBorg added the 6.topic: rust label May 19, 2018

Gerschtli force-pushed the fix/cargo-edit branch from aee4ef8 to 7420d08 Compare May 19, 2018 15:29

GrahamcOfBorg removed the 6.topic: rust label May 19, 2018

cargo-edit: Fixes build with carnix

13fb673

Gerschtli force-pushed the fix/cargo-edit branch from 7420d08 to 13fb673 Compare May 29, 2018 18:03

xeji mentioned this pull request May 31, 2018

cargo-edit: 0.1.6 -> 0.3.0-beta.1 #41301

Closed

xeji merged commit 56023ac into NixOS:master May 31, 2018

Gerschtli deleted the fix/cargo-edit branch June 1, 2018 13:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes cargo-edit #39348

Fixes cargo-edit #39348

Gerschtli commented Apr 22, 2018

Gerschtli commented May 16, 2018

matthewbauer commented May 17, 2018

GrahamcOfBorg commented May 17, 2018

GrahamcOfBorg commented May 17, 2018

GrahamcOfBorg commented May 17, 2018

Gerschtli commented May 17, 2018

matthewbauer commented May 17, 2018

GrahamcOfBorg commented May 17, 2018

GrahamcOfBorg commented May 17, 2018

GrahamcOfBorg commented May 17, 2018

Gerschtli commented May 19, 2018

xeji commented May 31, 2018

GrahamcOfBorg commented May 31, 2018

GrahamcOfBorg commented May 31, 2018

GrahamcOfBorg commented May 31, 2018

Gerschtli commented May 31, 2018

xeji commented May 31, 2018

matthewbauer commented May 31, 2018

xeji commented May 31, 2018

Fixes cargo-edit #39348

Fixes cargo-edit #39348

Conversation

Gerschtli commented Apr 22, 2018

Motivation for this change

Things done

Gerschtli commented May 16, 2018

matthewbauer commented May 17, 2018

GrahamcOfBorg commented May 17, 2018

GrahamcOfBorg commented May 17, 2018

GrahamcOfBorg commented May 17, 2018

Gerschtli commented May 17, 2018

matthewbauer commented May 17, 2018

GrahamcOfBorg commented May 17, 2018

GrahamcOfBorg commented May 17, 2018

GrahamcOfBorg commented May 17, 2018

Gerschtli commented May 19, 2018

xeji commented May 31, 2018

GrahamcOfBorg commented May 31, 2018

GrahamcOfBorg commented May 31, 2018

GrahamcOfBorg commented May 31, 2018

Gerschtli commented May 31, 2018

xeji commented May 31, 2018

matthewbauer commented May 31, 2018

xeji commented May 31, 2018