Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dejavu-fonts: fix missing Perl IOString dependency #39341

Merged
merged 2 commits into from Apr 22, 2018
Merged

dejavu-fonts: fix missing Perl IOString dependency #39341

merged 2 commits into from Apr 22, 2018

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Apr 22, 2018

Per the docs, IOString was recently added as a dependency:
https://github.com/dejavu-fonts/dejavu-fonts/blob/master/BUILDING.md

As-is, attempting to rebulid from source errors out with this missing perl module.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@bhipple
dejavu-fonts: fix missing Perl IOString dependency
a7c74bc 
Per the docs, IOString was recently added as a dependency:
https://github.com/dejavu-fonts/dejavu-fonts/blob/master/BUILDING.md

As-is, attempting to rebulid from source errors out with this missing perl module.
@bhipple
Copy link
Contributor Author

bhipple commented Apr 22, 2018

@GrahamcOfBorg build dejavu_fonts

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: dejavu_fonts

Partial log (click to expand)

these paths will be fetched (2.23 MiB download, 9.02 MiB unpacked):
  /nix/store/95aj70d0xhsicmv0w9fmgkdqi1r37n08-dejavu-fonts-2.37
copying path '/nix/store/95aj70d0xhsicmv0w9fmgkdqi1r37n08-dejavu-fonts-2.37' from 'https://cache.nixos.org'...
/nix/store/95aj70d0xhsicmv0w9fmgkdqi1r37n08-dejavu-fonts-2.37

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: dejavu_fonts

Partial log (click to expand)

/nix/store/95aj70d0xhsicmv0w9fmgkdqi1r37n08-dejavu-fonts-2.37

@Mic92 Mic92 merged commit 9e9cc47 into NixOS:master Apr 22, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: dejavu_fonts

Partial log (click to expand)

/nix/store/95aj70d0xhsicmv0w9fmgkdqi1r37n08-dejavu-fonts-2.37

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: dejavu_fonts

Partial log (click to expand)

/nix/store/95aj70d0xhsicmv0w9fmgkdqi1r37n08-dejavu-fonts-2.37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bhipple @GrahamcOfBorg @Mic92