reuse indexOf
#16570
Merged
reuse indexOf
#16570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bekzod
force-pushed
the
reuse-indexof
branch
2 times, most recently
from
58730a6
to
8528a3a
Compare
rwjblue
reviewed
Apr 22, 2018
| @@ -1094,10 +1078,11 @@ const ArrayMixin = Mixin.create(Enumerable, { | |||
| } | |||
|
|
|||
| let ret = A(); | |||
| // SameValueZero comparison (NaN !== NaN) | |||
| let predicate = value === value ? item => item === value : item => item !== item; | |||
There was a problem hiding this comment.
Why move this up to a function? Doesn’t seem to simplify or correct anything here...
There was a problem hiding this comment.
I will move it to #16569 which will make more sense there, thanks
|
Merging the other PR made a conflict here, can you fix it up? |
bekzod
force-pushed
the
reuse-indexof
branch
3 times, most recently
from
b21302e
to
f70a194
Compare
rwjblue
approved these changes
Apr 22, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.