Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trezord: Added Trezor Model-T (v2) udev rules #39322

Merged
merged 1 commit into from Apr 23, 2018
Merged

trezord: Added Trezor Model-T (v2) udev rules #39322

merged 1 commit into from Apr 23, 2018

Conversation

elitak
Copy link
Contributor

@elitak elitak commented Apr 22, 2018 •
edited

Motivation for this change

This adds udev rules for the new Trezor 2, "Model-T". I'm not real sure if both product ids and the extra MODE and TAGs are necessary, but I just copied what was advised upstream.

Things done

Restarted udev with the new rules and it picked up the Trezor when plugged in.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Apr 22, 2018

cc @oconnorr

jb55
jb55 approved these changes Apr 22, 2018
View reviewed changes
Copy link
Contributor

@jb55 jb55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 4bf61fa

@adisbladis adisbladis merged commit dd486e6 into NixOS:master Apr 23, 2018
@adisbladis
Copy link
Member

Backported to 18.03 in 14656d7.

@elitak elitak deleted the trezor branch December 29, 2018 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jb55 jb55 jb55 approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@elitak @Mic92 @adisbladis @jb55 @GrahamcOfBorg