Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cc-wrapper use xargs #39353

Closed
wants to merge 17 commits into from
Closed

cc-wrapper use xargs #39353

wants to merge 17 commits into from

Conversation

matthewbauer
Copy link
Member

Fixes #39175 (hopefully)

This moves the cc-wrapper call to xargs which hopefully can manage the arguments correctly. This is untested but I'm hoping it will work.

Relevant build log:

/nix/store/8b0gj3bmcy5bh1zcnhn0146199b3m5kb-clang-wrapper-5.0.1/bin/clang++: line 183: /nix/store/p85m242dg1zd85ln3cg0agx0q1n0n6h0-clang-5.0.1/bin/clang++: Argument list too long

https://hydra.nixos.org/build/73059537/nixlog/1
https://hydra.nixos.org/build/73059537

jluttine and others added 17 commits April 22, 2018 22:43
@jluttine
diskrsync: fix argv0
0f92afd 
When using diskrsync over SSH, on the remote machine it calls an executable
equal to argv0. Typically, this is just diskrsync but now that diskrsync is
wrapped, the wrapper uses absolute path to diskrsync and that path doesn't most
likely work on the remote machine. Thus, we need to force argv0 to "diskrsync"
so that it works on the remote machine.
@Balletie
pythonPackages.html5-parser: 0.4.4 -> 0.4.5
ef47a58
@matthewbauer
mono: allow custom meta in generic
b577f32
@matthewbauer
mono: add knownVulnerabilities for 4.0.4
6e0a68b 
http://www.mono-project.com/docs/about-mono/vulnerabilities/#string-to-double-parser-bug
@matthewbauer
Revert "initial TBS driver"
6a4cc35
@matthewbauer
Merge pull request NixOS#39345 from NixOS/revert-32049-tbs
3aea9a4 
Revert "initial TBS driver"
@MostAwesomeDude @Mic92
enhanced-ctorrent: fix CVE-2009-1759 (NixOS#39311)
69f23d9 
Patches from Debian.
@timokau
arb: 2.8.1 -> 2.13.0
1dbdffa
@timokau
eclib: 20160720 -> 20171002
a055816
@matthewbauer
Merge pull request NixOS#39344 from matthewbauer/mono-fixes
6ec7c39 
Mono: add vulnerabilities
@Mic92
Merge pull request NixOS#39347 from timokau/eclib-20171002
12e3bea 
eclib: 20160720 -> 20171002
@Mic92
Merge pull request NixOS#39346 from timokau/arb-2.13.0
cf540dd 
arb: 2.8.1 -> 2.13.0
@bhipple @Mic92
dejavu-fonts: fix missing Perl IOString dependency (NixOS#39341)
9e9cc47 
Per the docs, IOString was recently added as a dependency:
https://github.com/dejavu-fonts/dejavu-fonts/blob/master/BUILDING.md

As-is, attempting to rebulid from source errors out with this missing perl module.
@Mic92
Merge pull request NixOS#39339 from jluttine/fix-diskrsync-argv0
f2129ae 
diskrsync: fix argv0
@Mic92
Merge pull request NixOS#39343 from Balletie/master
9814515 
pythonPackages.html5-parser: 0.4.4 -> 0.4.5
@Mic92
zfs: mark as broken for 4.16
bc7c7b2
@matthewbauer
cc-wrapper: use xargs
cc36674 
Fixes NixOS#39175

(hopefully)
@dezgeg
Copy link
Contributor

dezgeg commented Apr 23, 2018

This isn't going to work unless I'm really missing something. Say, if your call is of the form clang <flag 1> <flag 2> <filename 1> <filename 2> <flag 3> <flag 4> it's going to be split up to two commands, say

clang <flag 1> <flag 2> <filename 1>
clang <filename 2> <flag 3> <flag 4>

which will do something completely different.

@matthewbauer
Copy link
Member Author

Yep nevermind on this then! I was misunderstanding how xargs works. I thought there was some special interface that bypassed ARG_MAX.

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: diskrsync, enhanced-ctorrent

The following builds were skipped because they don't evaluate on x86_64-darwin: arb, eclib, mono, zfs

Partial log (click to expand)

cannot build derivation '/nix/store/xvamwg2qls37sih26xx6izbkcsc297vp-top-osx-10.11.6.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/nxgc676689n7pdhzvx9gzxw5p2p8lm00-system_cmds-osx-10.11.6.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/95hfs2h1jj96m0kgrrc4f762pgjspbrw-top.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/pg4ijgzlczrzq2837gzhrfpvcih3pynd-sysctl.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/ks41rcflpvvicf2sfh0fyqmrvg12srdw-procps-compat.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/wsz63id6265nb0xazjamcmin019b33f9-go-1.10.1.drv': 21 dependencies couldn't be built
cannot build derivation '/nix/store/7fbm5jscvmlr54bjbzwnafv68n3k2abx-parallel-20180322.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/z1cq2m68p8ima0cwyyxjfyxpwgp8q5kl-govers-20150109-3b5f175.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/ybzzi2x5w8xjic0yhbh31w9z3i18qyh3-diskrsync-unstable-2018-02-03.drv': 8 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/hmv2f82k5rd1l1j6apr86yxi3llwg927-enhanced-ctorrent.drv', '/nix/store/ybzzi2x5w8xjic0yhbh31w9z3i18qyh3-diskrsync-unstable-2018-02-03.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: arb, diskrsync, eclib, enhanced-ctorrent, zfs

The following builds were skipped because they don't evaluate on aarch64-linux: mono

Partial log (click to expand)

cannot build derivation '/nix/store/5ya35x1y4w0gf42gjjmkp5bvm4n7b3g7-python2.7-hg-git-0.8.11.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/1i9z72qqdi8nb9l73iqd0y55slcxhwn0-mercurial-4.5.2.drv': 11 dependencies couldn't be built
cannot build derivation '/nix/store/kpbk8xn1jn65dg3kdlfsxb2m09sd7mqz-texlive-core-big.bin-2017.drv': 20 dependencies couldn't be built
cannot build derivation '/nix/store/q1zpa37fyjbcgvbd70cabcy3z2m12xpv-go-1.10.1.drv': 19 dependencies couldn't be built
cannot build derivation '/nix/store/gnjjz08m8vq79vvb2r3d2iq6a3yirb95-texlive-combined-basic-2017.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/nw4xpmjzgng8am9hvi9yrg6rhbx9zmmb-govers-20150109-3b5f175.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/zlx6k9j1m80vxjpki0d9rp6mmm0fcwdy-pari-2.9.4.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/fc7gvhcs4j5dbgvwyz63l33a3ns3acia-diskrsync-unstable-2018-02-03.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/66n90x7qgaklz0fjh0nvxvmqsi8asmi7-eclib-20171002.drv': 6 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/66n90x7qgaklz0fjh0nvxvmqsi8asmi7-eclib-20171002.drv', '/nix/store/c1qldgjbc24jyxlzi827xfm4iy9qk5g0-arb-2.13.0.drv', '/nix/store/fc7gvhcs4j5dbgvwyz63l33a3ns3acia-diskrsync-unstable-2018-02-03.drv', '/nix/store/krrx3n84axxjyyym9fz16ynpfkwrmc00-enhanced-ctorrent.drv', '/nix/store/n2wd73qcc4is7gxfk2082y1p0fc2q0k6-zfs-user-0.7.8.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: arb, diskrsync, eclib, enhanced-ctorrent, zfs

The following builds were skipped because they don't evaluate on x86_64-linux: mono

Partial log (click to expand)

cannot build derivation '/nix/store/9a47c7cv7nbr6mamgsasj1x5m2h94599-python2.7-hg-git-0.8.11.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/vfmw41cfwih6yx4b5bsa94xdp7j7xpsa-mercurial-4.5.2.drv': 11 dependencies couldn't be built
cannot build derivation '/nix/store/qsq6zyircrnd5a3991qjvi133k5f2v15-texlive-core-big.bin-2017.drv': 20 dependencies couldn't be built
cannot build derivation '/nix/store/dkcfc33zyc7xjp5pa0q10zqc18d6ymdv-go-1.10.1.drv': 19 dependencies couldn't be built
cannot build derivation '/nix/store/dpnp9svfjgh0d4b2g4pq7y2n2s7n8hj3-texlive-combined-basic-2017.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/yi7a44mr30915lw6y2757bsjircjh7zs-govers-20150109-3b5f175.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/jcv9jhl45xinkyxshshwkf5463nqkd7q-pari-2.9.4.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/g53dc8cwxpl5v8vw9bp5bjbcq96myzsd-diskrsync-unstable-2018-02-03.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/mbxx81ckah76sa1savgzpdnv3w4l0cjp-eclib-20171002.drv': 6 dependencies couldn't be built
error: build of '/nix/store/g53dc8cwxpl5v8vw9bp5bjbcq96myzsd-diskrsync-unstable-2018-02-03.drv', '/nix/store/g85zs6mcyzmwwvd3v4gl123s6v0kyb2a-enhanced-ctorrent.drv', '/nix/store/mbxx81ckah76sa1savgzpdnv3w4l0cjp-eclib-20171002.drv', '/nix/store/w2h6vns4jrrh9alg8wa31046mfmvkr0c-zfs-user-0.7.8.drv', '/nix/store/z13r4y1q7chxvhgzfva73bpgyhznrryi-arb-2.13.0.drv' failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314 Ericson2314 is a code owner

@FRidh FRidh Awaiting requested review from FRidh

@orivej orivej Awaiting requested review from orivej

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@matthewbauer @dezgeg @GrahamcOfBorg @jluttine @Balletie @MostAwesomeDude @timokau @Mic92 @bhipple