Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memtest86plus: fix, switch to using coreboot's branch #39335

Merged
merged 2 commits into from Apr 22, 2018
Merged

memtest86plus: fix, switch to using coreboot's branch #39335

merged 2 commits into from Apr 22, 2018

Conversation

oxij
Copy link
Member

@oxij oxij commented Apr 22, 2018

Motivation for this change

It failed to work on my Thinkpad X230. This fixes it both with Lenovo BIOS and with coreboot. I think the first patch should be backported to 18.03.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • other Linux distributions
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@oxij
memtest86plus: disable all hardening
1fb6bc4 
With hardening enabled it reports errors on known-good memory modules
on my Thinkpad X230 (Ivy Bridge). It's the same bug as reported in
https://bugs.launchpad.net/ubuntu/+source/memtest86+/+bug/1071209 but
memtest86+ fails on test NixOS#9 instead of test NixOS#7 (because NixOS#7 in 4.20
became NixOS#9 in 5.01) and with all the addresses multiplied by 2 (I guess
the bug was reported for i686, and I test on x86_64, it was 2012 after
all).
@oxij
memtest86plus: 5.01 -> 5.01+coreboot-20180113
983a3f1 
aka 5.01+coreboot-001+

The version maintained by coreboot project is superior to Debian, it
integrates all the Debian patches and fixes a bunch more bugs.

In particular, it fixes SMP freezes and apparent memory errors when
running under coreboot ROM.
@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: memtest86plus

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: memtest86plus

Partial log (click to expand)

as -32   -o setup.pre.o setup.pre.s
ld -z max-page-size=0x1000 -T memtest.bin.lds bootsect.pre.o setup.pre.o -b binary \
memtest_shared.bin -o memtest.bin
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/943rdxs64wdbbk4ci1gqzrgq8fdrjrqn-memtest86+-5.01+coreboot-20180113
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/943rdxs64wdbbk4ci1gqzrgq8fdrjrqn-memtest86+-5.01+coreboot-20180113
checking for references to /build in /nix/store/943rdxs64wdbbk4ci1gqzrgq8fdrjrqn-memtest86+-5.01+coreboot-20180113...
/nix/store/943rdxs64wdbbk4ci1gqzrgq8fdrjrqn-memtest86+-5.01+coreboot-20180113

@dezgeg dezgeg merged commit c314894 into NixOS:master Apr 22, 2018
@oxij
Copy link
Member Author

oxij commented Apr 22, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oxij @GrahamcOfBorg @dezgeg