Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bashplotlib: init at 2017-10-11 #40685

Merged
merged 1 commit into from May 17, 2018
Merged

bashplotlib: init at 2017-10-11 #40685

merged 1 commit into from May 17, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented May 17, 2018

"Plotting in the terminal"

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: bashplotlib

Partial log (click to expand)

writing entry points to bashplotlib.egg-info/entry_points.txt
reading manifest file 'bashplotlib.egg-info/SOURCES.txt'
writing manifest file 'bashplotlib.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/4s8s1hhb26b8ddhl956pfbqmkmf0y8mv-bashplotlib-2017-10-11

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: bashplotlib

Partial log (click to expand)

writing entry points to bashplotlib.egg-info/entry_points.txt
reading manifest file 'bashplotlib.egg-info/SOURCES.txt'
writing manifest file 'bashplotlib.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/rj3v72pi20gkpxvbs086782lv3wvhjzv-bashplotlib-2017-10-11

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: bashplotlib

Partial log (click to expand)

writing entry points to bashplotlib.egg-info/entry_points.txt
reading manifest file 'bashplotlib.egg-info/SOURCES.txt'
writing manifest file 'bashplotlib.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/r456z674sgaxxjmfyhshylvnimz4bvhm-bashplotlib-2017-10-11

FRidh
FRidh requested changes May 17, 2018
View reviewed changes
pkgs/tools/misc/bashplotlib/default.nix Outdated
{ stdenv, pythonPackages, fetchFromGitHub }:

pythonPackages.buildPythonApplication rec {
name = "bashplotlib-${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name attribute is added by buildPython* and should therefore be removed. Just add pname and version

@FRidh
Copy link
Member

FRidh commented May 17, 2018 

Ran 0 tests in 0.000s

No tests are found. Either the test runner cannot find tests and needs to be patched, or there simply are no tests in which case the tests need to be disabled. Do include a comment explaining why the tests are disabled.

@dtzWill
Copy link
Member Author

dtzWill commented May 17, 2018

Updated to address feedback, thanks! AFAICT no tests --closest are examples of usage but that not really the same :).

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: bashplotlib

Partial log (click to expand)

/build/source
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/vnq3bn6hnkrccx4qvd781hbrwm9azc91-bashplotlib-2017-10-11-2017-10-11
strip is /nix/store/jk6j4lh9v5mvjdbdc35sj0zffhhf6s56-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vnq3bn6hnkrccx4qvd781hbrwm9azc91-bashplotlib-2017-10-11-2017-10-11/lib  /nix/store/vnq3bn6hnkrccx4qvd781hbrwm9azc91-bashplotlib-2017-10-11-2017-10-11/bin
patching script interpreter paths in /nix/store/vnq3bn6hnkrccx4qvd781hbrwm9azc91-bashplotlib-2017-10-11-2017-10-11
checking for references to /build in /nix/store/vnq3bn6hnkrccx4qvd781hbrwm9azc91-bashplotlib-2017-10-11-2017-10-11...
wrapping `/nix/store/vnq3bn6hnkrccx4qvd781hbrwm9azc91-bashplotlib-2017-10-11-2017-10-11/bin/scatter'...
wrapping `/nix/store/vnq3bn6hnkrccx4qvd781hbrwm9azc91-bashplotlib-2017-10-11-2017-10-11/bin/hist'...
/nix/store/vnq3bn6hnkrccx4qvd781hbrwm9azc91-bashplotlib-2017-10-11-2017-10-11

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: bashplotlib

Partial log (click to expand)

Installing collected packages: bashplotlib
Successfully installed bashplotlib-0.6.5
/private/tmp/nix-build-bashplotlib-2017-10-11-2017-10-11.drv-0/source
post-installation fixup
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/624zl6qsd8cxnn1s3wm97g84lb6if2xh-bashplotlib-2017-10-11-2017-10-11/lib  /nix/store/624zl6qsd8cxnn1s3wm97g84lb6if2xh-bashplotlib-2017-10-11-2017-10-11/bin
patching script interpreter paths in /nix/store/624zl6qsd8cxnn1s3wm97g84lb6if2xh-bashplotlib-2017-10-11-2017-10-11
wrapping `/nix/store/624zl6qsd8cxnn1s3wm97g84lb6if2xh-bashplotlib-2017-10-11-2017-10-11/bin/hist'...
wrapping `/nix/store/624zl6qsd8cxnn1s3wm97g84lb6if2xh-bashplotlib-2017-10-11-2017-10-11/bin/scatter'...
/nix/store/624zl6qsd8cxnn1s3wm97g84lb6if2xh-bashplotlib-2017-10-11-2017-10-11

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: bashplotlib

Partial log (click to expand)

/build/source
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ri56qpi5xgcdbdl47cxclfwm9l2y001r-bashplotlib-2017-10-11-2017-10-11
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ri56qpi5xgcdbdl47cxclfwm9l2y001r-bashplotlib-2017-10-11-2017-10-11/lib  /nix/store/ri56qpi5xgcdbdl47cxclfwm9l2y001r-bashplotlib-2017-10-11-2017-10-11/bin
patching script interpreter paths in /nix/store/ri56qpi5xgcdbdl47cxclfwm9l2y001r-bashplotlib-2017-10-11-2017-10-11
checking for references to /build in /nix/store/ri56qpi5xgcdbdl47cxclfwm9l2y001r-bashplotlib-2017-10-11-2017-10-11...
wrapping `/nix/store/ri56qpi5xgcdbdl47cxclfwm9l2y001r-bashplotlib-2017-10-11-2017-10-11/bin/scatter'...
wrapping `/nix/store/ri56qpi5xgcdbdl47cxclfwm9l2y001r-bashplotlib-2017-10-11-2017-10-11/bin/hist'...
/nix/store/ri56qpi5xgcdbdl47cxclfwm9l2y001r-bashplotlib-2017-10-11-2017-10-11

xeji
xeji approved these changes May 17, 2018
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple tool.

@xeji xeji merged commit 3432fa3 into NixOS:master May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

@xeji xeji xeji approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @GrahamcOfBorg @FRidh @xeji