New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tomcat service: fix webapps default option #40657
Conversation
The old package tomcat.webapps does not exist
The old package tomcat.webapps does not exist (cherry picked from commit 1daa771)
backported in 3939055 |
This breaks evaluation on master (and 18.03) since Running the bundled nixos-test would have shown:
The output from hydra can be found at https://hydra.nixos.org/jobset/nixos/release-18.03#tabs-errors. Just to be sure lets ask what @GrahamcOfBorg thinks about this. |
No attempt on x86_64-linux (full log) The following builds were skipped because they don't evaluate on x86_64-linux: tests.tomcat Partial log (click to expand)
|
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: tests.tomcat Partial log (click to expand)
|
A potential solution would look like this: --- a/nixos/modules/services/web-servers/tomcat.nix
+++ b/nixos/modules/services/web-servers/tomcat.nix
@@ -109,8 +109,8 @@ in
webapps = mkOption {
type = types.listOf types.package;
- default = [ tomcat85.webapps ];
- defaultText = "[ tomcat85.webapps ]";
+ default = [ tomcat.webapps ];
+ defaultText = "[ pkgs.tomcat85.webapps ]";
description = "List containing WAR files or directories with WAR files which are web applications to be deployed on Tomcat";
}; (It is a bit hacky as it hides the truth about the webapps being picked from the selected tomcat by default... Is there a more elegant way?) |
(cherry picked from commit 93cbb9b)
The package referenced in the old default value does not exist in nixpkgs.
If accepted this should also be applied to release-18.03 branch.
Motivation for this change
Users were confused
/cc @armin1402