Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unbreak gv (fixes #34841) #40658

Merged
merged 1 commit into from May 19, 2018
Merged

Unbreak gv (fixes #34841) #40658

merged 1 commit into from May 19, 2018

Conversation

iblech
Copy link
Contributor

@iblech iblech commented May 17, 2018

It appears that without pkgconfig, the build process misdetects some features, resulting in gv to segfault immediately on startup.

The fix was adopted from Homebrew/legacy-homebrew#18555 (comment). I don't claim to know the proper background of this error; but I can confirm that with this change, gv works as it should.

Motivation for this change

In current NixOS unstable, gv builds, but immediately segfaults on startup.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@iblech
Unbreak gv (fixes NixOS#34841)
99f9095 
It appears that without pkgconfig, the build process misdetects some features, resulting in gv to segfault immediately on startup.

The fix was adopted from Homebrew/legacy-homebrew#18555 (comment).
@xeji
Copy link
Contributor

xeji commented May 19, 2018

@GrahamcOfBorg build gv

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: gv

Partial log (click to expand)

  /nix/store/mskalqsknpxbqqr4gyzb5vwr9pan6gn5-jbig2dec-0.14
  /nix/store/z1q714k7v2dr2cii2dq7s0phd3azs9h8-libpaper-1.1.24
copying path '/nix/store/hlv6ffrfyb4a5iaaz1g640k8srq430kp-Xaw3d-1.6.2' from 'https://cache.nixos.org'...
copying path '/nix/store/5yalrsx2z0na727nw36iz5zzgzz9yw93-cups-2.2.6-lib' from 'https://cache.nixos.org'...
copying path '/nix/store/mskalqsknpxbqqr4gyzb5vwr9pan6gn5-jbig2dec-0.14' from 'https://cache.nixos.org'...
copying path '/nix/store/z1q714k7v2dr2cii2dq7s0phd3azs9h8-libpaper-1.1.24' from 'https://cache.nixos.org'...
copying path '/nix/store/aqwzv6r1541yyv5plaimjm5g2q2n568a-cups-2.2.6' from 'https://cache.nixos.org'...
copying path '/nix/store/ggya7xfsr6vvnk18ki6cphwkwxl50q4h-ghostscript-9.22' from 'https://cache.nixos.org'...
copying path '/nix/store/8406ry2rv0pzbv0840v7khmglwz3lrrc-gv-3.7.4' from 'https://cache.nixos.org'...
/nix/store/8406ry2rv0pzbv0840v7khmglwz3lrrc-gv-3.7.4

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gv

Partial log (click to expand)

make[1]: Leaving directory '/build/gv-3.7.4'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5fbjmqi1rcrbx1qliymwg04kgzh1sm27-gv-3.7.4
shrinking /nix/store/5fbjmqi1rcrbx1qliymwg04kgzh1sm27-gv-3.7.4/bin/gv
gzipping man pages under /nix/store/5fbjmqi1rcrbx1qliymwg04kgzh1sm27-gv-3.7.4/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5fbjmqi1rcrbx1qliymwg04kgzh1sm27-gv-3.7.4/bin
patching script interpreter paths in /nix/store/5fbjmqi1rcrbx1qliymwg04kgzh1sm27-gv-3.7.4
/nix/store/5fbjmqi1rcrbx1qliymwg04kgzh1sm27-gv-3.7.4/bin/gv-update-userconfig: interpreter directive changed from " /usr/bin/perl" to "/nix/store/cxdmh98g0lvl1dyq304c1lq7f90dh01f-perl-5.24.3/bin/perl"
checking for references to /build in /nix/store/5fbjmqi1rcrbx1qliymwg04kgzh1sm27-gv-3.7.4...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gv

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/702bn4z4fzf88a8vcmchr6d321d79n75-gv-3.7.4
shrinking /nix/store/702bn4z4fzf88a8vcmchr6d321d79n75-gv-3.7.4/bin/gv
gzipping man pages under /nix/store/702bn4z4fzf88a8vcmchr6d321d79n75-gv-3.7.4/share/man/
strip is /nix/store/jk6j4lh9v5mvjdbdc35sj0zffhhf6s56-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/702bn4z4fzf88a8vcmchr6d321d79n75-gv-3.7.4/bin
patching script interpreter paths in /nix/store/702bn4z4fzf88a8vcmchr6d321d79n75-gv-3.7.4
/nix/store/702bn4z4fzf88a8vcmchr6d321d79n75-gv-3.7.4/bin/gv-update-userconfig: interpreter directive changed from " /usr/bin/perl" to "/nix/store/lind05r5ydb20phsj39zf7kyjkavwj02-perl-5.24.3/bin/perl"
checking for references to /build in /nix/store/702bn4z4fzf88a8vcmchr6d321d79n75-gv-3.7.4...
/nix/store/702bn4z4fzf88a8vcmchr6d321d79n75-gv-3.7.4

@xeji xeji merged commit fac3587 into NixOS:master May 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iblech @xeji @GrahamcOfBorg