nixos/kubernetes: Update kube-dns and kube-dashbashboard docker image… #40665
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… derivations to new pullImage function signature
Motivation for this change
Hi,
I tried to run kubernetes on my nixos/unstable system. Unfortunately nix refused to build kube-dns and kube-dashboard. It looks like this is caused by a change in the function signature of
pkgs/build-tools/docker/default.nix:pullImage
. This patch tries to fix that.I tested the module on my local system, but unfortunately the nixos tests for kubernetes are not "working" for other reasons I do not understand quite right. However, the build failure does not occur anymore with this patch and the problems arise for me at runtime and seem -- as far as I understand -- not related to the thing this patch tries fix.Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)