Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/kubernetes: Update kube-dns and kube-dashbashboard docker image… #40665

Merged
merged 1 commit into from May 24, 2018

Conversation

seppeljordan
Copy link
Contributor

@seppeljordan seppeljordan commented May 17, 2018

… derivations to new pullImage function signature

Motivation for this change

Hi,
I tried to run kubernetes on my nixos/unstable system. Unfortunately nix refused to build kube-dns and kube-dashboard. It looks like this is caused by a change in the function signature of pkgs/build-tools/docker/default.nix:pullImage. This patch tries to fix that.

I tested the module on my local system, but unfortunately the nixos tests for kubernetes are not "working" for other reasons I do not understand quite right. However, the build failure does not occur anymore with this patch and the problems arise for me at runtime and seem -- as far as I understand -- not related to the thing this patch tries fix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

… derivations to new pullImage function signature
@nlewo
Copy link
Member

nlewo commented May 17, 2018

@GrahamcOfBorg test kubernetes

@GrahamcOfBorg
Copy link

Success on x86_64-linux

Attempted: tests.kubernetes

No partial log is available.

@GrahamcOfBorg
Copy link

Success on aarch64-linux

Attempted: tests.kubernetes

No partial log is available.

@nlewo
Copy link
Member

nlewo commented May 20, 2018

Kubernetes tests are locally passing.
Thanks.

@nlewo nlewo merged commit 4ccb13a into NixOS:master May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants