m32edit and x32edit: init at 3.2 #40666
Conversation
| @@ -0,0 +1,43 @@ | |||
| { stdenv, fetchurl, lib, libX11, libXext, alsaLib, freetype }: | |||
| # // libStdCxx = stdenv.cc.cc.lib; | |||
| sha256 = "1cds6qinz37086l6pmmgrzrxadygjr2z96sjjyznnai2wz4z2nrd"; | ||
| }; | ||
|
|
||
| sourceRoot = "."; |
There was a problem hiding this comment.
It doesn't build without this.
| }; | ||
|
|
||
| sourceRoot = "."; | ||
| buildPhase = ":"; # nothing to build |
There was a problem hiding this comment.
It would be better to set the dontBuild=true attribute.
|
@magnetophon could you rename the attribute to |
|
@nlewo like this? |
|
Yes, I think you could create files |
|
@nlewo Thanks for the tip. |
| { stdenv, fetchurl, lib, libX11, libXext, alsaLib, freetype, brand, type, version, homepage, sha256, ... }: | ||
| stdenv.mkDerivation rec { | ||
| inherit type; | ||
| baseName = "${type}-Edit"; |
There was a problem hiding this comment.
By convention, could you call this attribute pname.
Moreover, the name of a package should not contain any uppercase letters.
There was a problem hiding this comment.
type is also with uppercase, since it's also used in the url and description.
Can I just do pname = "${type}-edit";,or would you suggest I use a string-manipulation function to change the case?
A function for that probably exists in nix, I've see similar things, but I have no idea how to find it.
|
You can use `toLower` I think. See https://github.com/NixOS/nixpkgs/blob/master/lib/strings.nix#L254.
|
|
@magnetophon Do you need help? I can also fix it for you because it's really close to be merged:/ |
|
@nlewo Thanks! Please do, my build sytem is messed up after a new install. |
|
Package name fixed in 5892931. |
|
Thanks a lot! |
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)