Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

faust2: fix build with llvm 5.0.2 [18.03] #40672

Merged
merged 1 commit into from May 21, 2018
Merged

faust2: fix build with llvm 5.0.2 [18.03] #40672

merged 1 commit into from May 21, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented May 17, 2018

Motivation for this change

Build was broken by llvm: 5.0.1 -> 5.0.2 (#39979) - error "unknown llvm version".
Fixed by adding 5.0.2 to the list of known llvm versions.
Opened upstream issue grame-cncm/faust#181.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji
faust2: fix build with llvm 5.0.2
e9c135a 
build was broken by  llvm: 5.0.1 -> 5.0.2 (NixOS#39979)
@xeji xeji changed the title [18.03] faust2: fix build with llvm 5.0.2 faust2: fix build with llvm 5.0.2 [18.03] May 17, 2018
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: faust2

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: faust2

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: faust2

Partial log (click to expand)

/nix/store/kcj7lr1lq00s3abcwb1mka6msnxgwj78-faust-2.5.21/share/faust/android/gradlew: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/kcj7lr1lq00s3abcwb1mka6msnxgwj78-faust-2.5.21/share/faust/smartKeyboard/android/gradlew: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/kcj7lr1lq00s3abcwb1mka6msnxgwj78-faust-2.5.21/bin/faustbench: interpreter directive changed from "/bin/bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/kcj7lr1lq00s3abcwb1mka6msnxgwj78-faust-2.5.21/bin/faustpath: interpreter directive changed from " /bin/bash -e" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash -e"
/nix/store/kcj7lr1lq00s3abcwb1mka6msnxgwj78-faust-2.5.21/bin/faust2svg: interpreter directive changed from " /bin/bash -e" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash -e"
/nix/store/kcj7lr1lq00s3abcwb1mka6msnxgwj78-faust-2.5.21/bin/encoderunitypackage: interpreter directive changed from " /bin/bash -e" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash -e"
/nix/store/kcj7lr1lq00s3abcwb1mka6msnxgwj78-faust-2.5.21/bin/sound2reader: interpreter directive changed from "/bin/bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/kcj7lr1lq00s3abcwb1mka6msnxgwj78-faust-2.5.21/bin/faustoptflags: interpreter directive changed from "/bin/bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
checking for references to /build in /nix/store/kcj7lr1lq00s3abcwb1mka6msnxgwj78-faust-2.5.21...
/nix/store/kcj7lr1lq00s3abcwb1mka6msnxgwj78-faust-2.5.21

LnL7
LnL7 reviewed May 17, 2018
View reviewed changes
Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go to master first, or is that no longer a problem there?

@xeji
Copy link
Contributor Author

xeji commented May 17, 2018

llvm 5.0.2 is still in staging, so the faust2 issue hasn't appeared in master yet - and I didn't want to pick from staging (where not much builds currently) to 18.03...

@matthewbauer
Copy link
Member

So it looks like they are now preferring to use CMake. Would it be possible to just use that instead of Makefile.unix? Not sure if possible but might be worth looking into.

@xeji
Copy link
Contributor Author

xeji commented May 21, 2018

I'll give that a try.

@xeji
Copy link
Contributor Author

xeji commented May 21, 2018

After some experiments, migrating to CMake looks possible but I'm not sure how that would affect the different backends and related packages, and I don't know how to test everything.
So I'll merge this more conservative fix for 18.03 now.

For 18.09, I'd like to ask maintainers @magnetophon @pmahoney to look into using CMake.

@xeji xeji merged commit a16c312 into NixOS:release-18.03 May 21, 2018
@xeji xeji deleted the faust branch May 21, 2018 15:44
@magnetophon
Copy link
Member

@xeji Could you post those experiments, I'll test them.

@xeji
Copy link
Contributor Author

xeji commented May 21, 2018

@magnetophon thank you! xeji@f08409b is as far as I got. It builds faust2 but I have not tested the result at all, or even compared it to previous builds to see if anything's missing.

@magnetophon
Copy link
Member

Thanks!

That works here too, but when I try to use it I get an error.
I've submitted a bugreport upstream, but I'm not sure if that's where the issue lays.

@xeji
Copy link
Contributor Author

xeji commented May 25, 2018

Thanks! Let's see what upstream says...

xeji added a commit that referenced this pull request Jun 5, 2018
@xeji
faust2: fix build with llvm 5.0.2 (#40672)
44f3a1d 
build was broken by  llvm: 5.0.1 -> 5.0.2 (#39979)

(cherry picked from commit a16c312)
orivej added a commit that referenced this pull request Jun 6, 2018
@orivej
Merge branch 'master' into staging
91e1ec6 
* master: (63 commits)
  tests.cc-wrapper: do not test sanitizers on darwin
  nodePackages_8_x: Add nodejs (npm) to wrapper
  python.pkgs.cairocffi: support darwin
  osinfo-db: 20180514 -> 20180531 (#41532)
  pkcs11helper: 1.22 -> 1.23 (#41530)
  pmd: 6.3.0 -> 6.4.0 (#41529)
  renpy: 6.99.14.3 -> 7.0.0 (#41515)
  wireless-regdb: 2018.05.09 -> 2018.05.31 (#41502)
  gnuplot: 5.2.3 -> 5.2.4 (#41505)
  qrencode: 4.0.0 -> 4.0.1
  Revert "libbsd: replace with nbcompat"
  Revert "opendkim: fix libbsd dependency"
  Revert "libbsd-freedesktop: re-init at 0.9.1, use for samba"
  flent: fix fetchFromGitHub version
  syncthing: 0.14.47 -> 0.14.48
  pythonPackages.pykdtree: init at 1.3.0 (#41355)
  snd: 18.3 -> 18.4
  bat: support darwin
  faust2: fix build with llvm 5.0.2 (#40672)
  mc: 4.8.20 -> 4.8.21 (#41496)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@xeji @GrahamcOfBorg @matthewbauer @magnetophon @LnL7