Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tdesktop: fix icon path #40298

Merged
merged 1 commit into from May 11, 2018
Merged

tdesktop: fix icon path #40298

merged 1 commit into from May 11, 2018

Conversation

cruizh
Copy link
Contributor

@cruizh cruizh commented May 10, 2018 •
edited

Motivation for this change

The .desktop file now refers to the icon as telegram instead of telegram-desktop. This caused a placeholder icon to be shown instead.

Things done

Changed path of the tdesktop icon.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@cruizh
Fix tdesktop icon path
d9e1ed4 
The `.desktop` file now refers to the icon as `telegram` instead of `telegram-desktop`. This caused a placeholder icon to be shown instead.
@cruizh cruizh changed the title Fix tdesktop icon path tdesktop: fix icon path May 10, 2018
@primeos primeos self-assigned this May 11, 2018
@primeos primeos merged commit 5f8ee95 into NixOS:master May 11, 2018
@primeos
Copy link
Member

primeos commented May 11, 2018

Thanks :)

For some reason it was still working with gnome3 and palasma5 (at least for me) but this change definitely makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@primeos primeos

Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cruizh @primeos @GrahamcOfBorg