Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/systems: Prohibit "gnu" ABI (*-gnu) with 32-bit ARM #40297

Merged
merged 1 commit into from
May 10, 2018

Conversation

Ericson2314
Copy link
Member

Motivation for this change

It is ambiguous, and therefore banned within GCC.

@dezgeg doing this separately since it is eval-only, and I can therefore test it myself.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

It is ambiguous, and therefore banned within GCC.
@Ericson2314 Ericson2314 requested a review from nbp as a code owner May 10, 2018 19:14
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 10, 2018
@Ericson2314 Ericson2314 merged commit 5789cf4 into NixOS:master May 10, 2018
@Ericson2314 Ericson2314 deleted the arm-abi-disambig branch May 10, 2018 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants