Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: Simplify float handling #40307

Merged
merged 3 commits into from May 11, 2018
Merged

lib: Simplify float handling #40307

merged 3 commits into from May 11, 2018

Conversation

Ericson2314
Copy link
Member

Motivation for this change

Backport of #40306

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ericson2314
gcc: Factor out "platform flags"
c9f6a82
@Ericson2314
lib: Clean up float/fpu options
1fe81a4 
ARM ABIs now have a float field. This is used as a fallback to lessen
our use of `platform.gcc.float`. I didn't know what the MIPs convention
is so I kept using `platform.gcc.float` in that case.
@Ericson2314
glibc: Remove old-style nullable "cross" variable
e988144 
Much better to just use {build,host}Platform directly.
@Ericson2314 Ericson2314 requested a review from nbp as a code owner May 10, 2018 22:15
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: gcc

The following builds were skipped because they don't evaluate on x86_64-darwin: glibc

Partial log (click to expand)

copying path '/nix/store/0w4d8h3rzmz55qnsvjws3gp73s3b725m-expand-response-params' from 'https://cache.nixos.org'...
copying path '/nix/store/pmyyfc5y127c9gvbmqk2hjj22z2dlx7d-gcc-7.3.0-lib' from 'https://cache.nixos.org'...
copying path '/nix/store/4k5nnbr26xnykj70n0cwswz1rimq67c3-mpfr-3.1.6' from 'https://cache.nixos.org'...
copying path '/nix/store/5lji4d0yk40wyy429y1jf41nwp2rwmmx-cctools-port-895' from 'https://cache.nixos.org'...
copying path '/nix/store/ds22rag9dcqpnjkz8x0c25mk00r07prw-libmpc-1.1.0' from 'https://cache.nixos.org'...
copying path '/nix/store/rwa61h30fadi16nrih9nbsbhlywcrnsg-cctools-binutils-darwin' from 'https://cache.nixos.org'...
copying path '/nix/store/iqrx7h54ys5l2aiwb2q6xqimv6pyqr2s-gcc-7.3.0' from 'https://cache.nixos.org'...
copying path '/nix/store/gainma6wqqdiwgyljpsrmblv92ss0l98-cctools-binutils-darwin-wrapper' from 'https://cache.nixos.org'...
copying path '/nix/store/vbskscr5d782lwwnln3ncmjxj0sjp6xf-gcc-wrapper-7.3.0' from 'https://cache.nixos.org'...
/nix/store/vbskscr5d782lwwnln3ncmjxj0sjp6xf-gcc-wrapper-7.3.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gcc, glibc

Partial log (click to expand)

/nix/store/gqg2vrcq7krqi9rrl6pphvsg81sb8pjw-gcc-wrapper-7.3.0
/nix/store/2kcrj1ksd2a14bm5sky182fv2xwfhfap-glibc-2.26-131

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gcc, glibc

Partial log (click to expand)

/nix/store/sw52c97xmgshcjaapn5wb1qwb2zgdszg-gcc-wrapper-7.3.0
/nix/store/g4xzhvdrzmqqhl0byb70hvp8gzyw72qq-glibc-2.26-131

@Ericson2314 Ericson2314 merged commit ad1af29 into NixOS:release-18.03 May 11, 2018
@Ericson2314 Ericson2314 deleted the lib-float-for-18.03 branch May 11, 2018 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ericson2314 @GrahamcOfBorg @dezgeg