improve search to create new pages with odd name #2380
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
search query: Doku Wiki:Hello World new pagename with this fix: doku_wiki:hello_world new pagename without this: doku_wiki_hello_world (namespace not applied)
micgro42
requested changes
May 11, 2018
There was a problem hiding this comment.
I'm not sure this is necessary, but assuming that it is, please:
- See the failing test and fix your code so that it no longer fails
- Write a test that specifically checks for your own change
- do 1. and 2. in way that thoroughly considers the question of "For which arguments should your change not affect the result of this method?" Especially considering the rarer search syntax options: https://www.dokuwiki.org/search
|
I will go ahead to close this, but if you still have interest to polish the patch with the suggestions, you can open a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If search query contains white space and upper case letters, createQueryPageLink is created with unwanted pagename.
search query: Doku Wiki:Hello World
new pagename with this fix: doku_wiki:hello_world
new pagename without this: doku_wiki_hello_world (namespace not applied)