[FEAT] FASTBOOT SHOEBOX - Use actions queue so rehydration works #5439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Remaining test failure after rebase against |
runspired
changed the title
runspired
force-pushed
the
use-actions-queue-so-rehydration-works
branch
from
563b614
to
bbda934
Compare
krisselden
approved these changes
Apr 19, 2018
runspired
force-pushed
the
use-actions-queue-so-rehydration-works
branch
from
13530ed
to
d3eacea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fastboot Shoebox rehydration works at the adapter level, waiting until
afterRenderto flush fetches means that we can't rehydrate properly on the initial render. This fixes that for the common case of routes, but likely does not fix anything for components that fetch data.cc @krisselden