Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

farbfeld, sent: wrap PATH for 2ff and sent #39144

Merged
merged 1 commit into from Apr 22, 2018
Merged

farbfeld, sent: wrap PATH for 2ff and sent #39144

merged 1 commit into from Apr 22, 2018

Conversation

oxzi
Copy link
Member

@oxzi oxzi commented Apr 19, 2018

Motivation for this change

Both farbfeld's 2ff and sent depends on file/2ff to be available in the PATH. This PR wraps the programs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 merged commit 69ee53a into NixOS:master Apr 22, 2018
@Mic92
Copy link
Member

Mic92 commented Apr 22, 2018

18.03:

[detached HEAD 4adf3a7] farbfeld, sent: wrap PATH for 2ff and sent
Author: geistesk github.jyf300hj@0x21.biz
Date: Thu Apr 19 11:51:06 2018 +0200
2 files changed, 11 insertions(+), 3 deletions(-)

@oxzi oxzi deleted the farbfeld-sent-path branch April 22, 2018 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oxzi @Mic92 @GrahamcOfBorg