spdk: init at 18.04-pre #39138
Closed
spdk: init at 18.04-pre #39138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Storage Performance Development Kit (SPDK) provides a set of tools and libraries for writing high performance, scalable, user-mode storage applications.
matthewbauer
requested changes
Apr 22, 2018
|
|
||
| buildInputs = [ | ||
| cunit | ||
| gcc |
There was a problem hiding this comment.
This shouldn't be needed. It's implied when you use stdenv.
| owner = "spdk"; | ||
| rev = "a3f8876777762f9b99544b78ee0b24ff66266c5c"; | ||
| sha256 = "1hb22h8c8b3q91ypfj084ic8gw1fibhfckivfgl334hbbxvay0j0"; | ||
| fetchSubmodules = true; |
There was a problem hiding this comment.
It would be nice if could avoid this. I'm not sure how the build system works but we do have "dpdk" packaged already - maybe you can get spdk to use it?
|
|
||
| stdenv.mkDerivation rec { | ||
| name = "spdk-${version}"; | ||
| version = "v18.04-pre"; |
There was a problem hiding this comment.
Any reason for this? If possible I think we'd prefer v18.01 (and use the corresponding tag).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Storage Performance Development Kit (SPDK) provides a set of tools
and libraries for writing high performance, scalable, user-mode storage
applications.
Motivation for this change
To support the development of user-space storage drivers.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)