nixos lcdproc: module for lcdd/lcdproc #39137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Apr 22, 2018
| usbVid = mkOption { | ||
| type = str; | ||
| default = ""; | ||
| description = "The vendor ID of the USB device to claim."; |
There was a problem hiding this comment.
It would be helpful for end-users if a command was added that shows how to figure out these usb ids.
There was a problem hiding this comment.
Good point - added. I've also just come to the realization that writing docbook by hand is nasty....
There was a problem hiding this comment.
in the wiki we have some hints to improve editor setups: https://nixos.wiki/wiki/Docbook_Editor_Configuration
There was a problem hiding this comment.
That would not help in this case though.
Mic92
reviewed
Apr 25, 2018
| Set group-write permissions on a USB device. | ||
| </para> | ||
| <para> | ||
| A USB connected LCD panel will most likely require having its permissions modified for lcdd to write to it. Enabling this option sets group-write permissions on the device identified by <option>services.hardware.lcd.usbVid</option> and <option>services.hardware.lcd.usbPid</option>. In order to find the values, you can run the <command>lsusb</command> command. Example output:</para><para> |
There was a problem hiding this comment.
nitpick: Can you add line breaks here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
A basic module for reporting system info on an attached LCD.
The client and server parts are split up to allow it to run properly over the network.
I only have access to one piece of hardware so I cannot say how/if it will work with others.
The USB group handling is not very pretty in case the user selects a group that doesn't exist.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)