Fix Object.delegate to setter (#5964)

crystal-lang · Apr 19, 2018 · 34078b8 · 34078b8
1 parent 591580e
commit 34078b8
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 7 deletions.
diff --git a/spec/std/object_spec.cr b/spec/std/object_spec.cr
@@ -98,6 +98,13 @@ private class TestObject
   end
 end
 
+private class DelegatedTestObject
+  delegate "property1=", to: @test_object
+
+  def initialize(@test_object : TestObject)
+  end
+end
+
 private class TestObjectWithFinalize
   property key : Symbol?
 
@@ -129,6 +136,13 @@ describe Object do
       end
       matches.should eq(["l", "l"])
     end
+
+    it "delegates setter" do
+      test_object = TestObject.new
+      delegated = DelegatedTestObject.new(test_object)
+      delegated.property1 = 42
+      test_object.property1.should eq 42
+    end
   end
 
   describe "getter" do

diff --git a/src/object.cr b/src/object.cr
@@ -1083,15 +1083,21 @@ class Object
   # ```
   macro delegate(*methods, to object)
     {% for method in methods %}
-      def {{method.id}}(*args, **options)
-        {{object.id}}.{{method.id}}(*args, **options)
-      end
+      {% if method.id.ends_with?('=') %}
+        def {{method.id}}(arg)
+          {{object.id}}.{{method.id}} arg
+        end
+      {% else %}
+        def {{method.id}}(*args, **options)
+          {{object.id}}.{{method.id}}(*args, **options)
+        end
 
-      def {{method.id}}(*args, **options)
-        {{object.id}}.{{method.id}}(*args, **options) do |*yield_args|
-          yield *yield_args
+        def {{method.id}}(*args, **options)
+          {{object.id}}.{{method.id}}(*args, **options) do |*yield_args|
+            yield *yield_args
+          end
         end
-      end
+      {% end %}
     {% end %}
   end