Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tox: libtoxcore and assorted tox client updates #39147

Merged
merged 6 commits into from Apr 30, 2018
Merged

tox: libtoxcore and assorted tox client updates #39147

merged 6 commits into from Apr 30, 2018

Conversation

peterhoeg
Copy link
Member

Motivation for this change

libtoxcore made breaking changes in 0.2 so we now carry both 0.1 and 0.2 for use by the various clients.

Cc @ehmry @viric @jgeerds @akaWolf @domenkozar @cleverca22 @obadz

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@peterhoeg peterhoeg force-pushed the u/tox branch 2 times, most recently from e91d2d2 to 15ed642 Compare April 20, 2018 00:41
@Mic92
Copy link
Member

Mic92 commented Apr 22, 2018

@GrahamcOfBorg build toxvpn utox toxic qtox ratox libtoxcore

@Mic92
Copy link
Member

Mic92 commented Apr 22, 2018

evaluation error should be fixed.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: toxvpn, toxic, qtox, ratox, libtoxcore

The following builds were skipped because they don't evaluate on x86_64-linux: utox

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/rbip69b29rd1lzn2r5g0kc99fp4win30-qtox-1.15.0/bin
patching script interpreter paths in /nix/store/rbip69b29rd1lzn2r5g0kc99fp4win30-qtox-1.15.0
checking for references to /build in /nix/store/rbip69b29rd1lzn2r5g0kc99fp4win30-qtox-1.15.0...
postPatchMkspecs
postPatchMkspecs
/nix/store/89mnad7x7bzcl5lbhigrf27bx80zmcig-toxvpn-2018-04-17
/nix/store/8qb3ghgj9dhbf85vikpd20xwrqwc7dxd-toxic-0.8.2
/nix/store/rbip69b29rd1lzn2r5g0kc99fp4win30-qtox-1.15.0
/nix/store/f5faiqzd2bxnakgyd1nqicyci433jfn4-ratox-0.4.20180303
/nix/store/xx0cddp4v9cs3c5yzd8vnj79dmnr445d-libtoxcore-0.2.2

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: toxvpn, qtox, libtoxcore

The following builds were skipped because they don't evaluate on x86_64-darwin: utox, toxic, ratox

Partial log (click to expand)

/tmp/nix-build-qtox-1.15.0.drv-0/source/src/platform/camera/avfoundation.mm:24:9: fatal error: 'AVFoundation/AVFoundation.h' file not found
#import <AVFoundation/AVFoundation.h>
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make[2]: *** [CMakeFiles/qtox_static.dir/build.make:3571: CMakeFiles/qtox_static.dir/src/platform/camera/avfoundation.mm.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:106: CMakeFiles/qtox_static.dir/all] Error 2
make: *** [Makefile:141: all] Error 2
builder for '/nix/store/vp56fx6p4dxrcxl97lm0s7m6p380s1lm-qtox-1.15.0.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/vp56fx6p4dxrcxl97lm0s7m6p380s1lm-qtox-1.15.0.drv', '/nix/store/wscil2jz4glgf63icfcr1235lmscnlvv-toxvpn-2018-04-17.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: toxvpn, toxic, qtox, ratox, libtoxcore

The following builds were skipped because they don't evaluate on aarch64-linux: utox

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/nf4hgjf1qd14xd9yrl3klpvfckl2s1lk-qtox-1.15.0/bin
patching script interpreter paths in /nix/store/nf4hgjf1qd14xd9yrl3klpvfckl2s1lk-qtox-1.15.0
checking for references to /build in /nix/store/nf4hgjf1qd14xd9yrl3klpvfckl2s1lk-qtox-1.15.0...
postPatchMkspecs
postPatchMkspecs
/nix/store/ss0va26k49g3mzfxvxyz3jjpy7zylj5w-toxvpn-2018-04-17
/nix/store/xsl1v7xsls47mc07lsbn6jv2card9rvw-toxic-0.8.2
/nix/store/nf4hgjf1qd14xd9yrl3klpvfckl2s1lk-qtox-1.15.0
/nix/store/xp1ridl7my6sv28pgb1gshdwm493gipy-ratox-0.4.20180303
/nix/store/n1qn9i9qy8qd10fvq06505l2885cdzvn-libtoxcore-0.2.2

@peterhoeg
Copy link
Member Author

evaluation error should be fixed.

Indeed @Mic92, I just don't have a mac so it's going to be trial and error from here.

@Mic92
Copy link
Member

Mic92 commented Apr 23, 2018 •
edited

Nix evaluation errors should not be platform dependent and can be reproduced on other platforms.

@peterhoeg peterhoeg mentioned this pull request Apr 24, 2018
Closed
@peterhoeg peterhoeg force-pushed the u/tox branch 2 times, most recently from b84624f to be3810b Compare April 24, 2018 10:47
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libtoxcore, qtox, ratox, toxic, toxvpn, utox

Partial log (click to expand)

strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/n52xdnzx6wqlygh6fxjsrl47qlkqix4q-utox-0.17.0/bin
patching script interpreter paths in /nix/store/n52xdnzx6wqlygh6fxjsrl47qlkqix4q-utox-0.17.0
checking for references to /build in /nix/store/n52xdnzx6wqlygh6fxjsrl47qlkqix4q-utox-0.17.0...
/nix/store/xx0cddp4v9cs3c5yzd8vnj79dmnr445d-libtoxcore-0.2.2
/nix/store/rbip69b29rd1lzn2r5g0kc99fp4win30-qtox-1.15.0
/nix/store/f5faiqzd2bxnakgyd1nqicyci433jfn4-ratox-0.4.20180303
/nix/store/8qb3ghgj9dhbf85vikpd20xwrqwc7dxd-toxic-0.8.2
/nix/store/89mnad7x7bzcl5lbhigrf27bx80zmcig-toxvpn-2018-04-17
/nix/store/n52xdnzx6wqlygh6fxjsrl47qlkqix4q-utox-0.17.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libtoxcore, qtox, ratox, toxic, toxvpn, utox

Partial log (click to expand)

strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/v25i5inwkkw9klrjrx4x1qfcj2g9dj5a-toxvpn-2018-04-17/bin
patching script interpreter paths in /nix/store/v25i5inwkkw9klrjrx4x1qfcj2g9dj5a-toxvpn-2018-04-17
checking for references to /build in /nix/store/v25i5inwkkw9klrjrx4x1qfcj2g9dj5a-toxvpn-2018-04-17...
/nix/store/lir22fbzq5833chnrlkn39n40yqadf0z-libtoxcore-0.2.2
/nix/store/pil7ccdd9j0r33hv9zn7is5wghy49lbs-qtox-1.15.0
/nix/store/vglywllbd422g3fca8q09snfgk69iww8-ratox-0.4.20180303
/nix/store/0w963mxwckgc42m69k26farnd7n72qdb-toxic-0.8.2
/nix/store/v25i5inwkkw9klrjrx4x1qfcj2g9dj5a-toxvpn-2018-04-17
/nix/store/d7byjixlblkpgcrrq0zcizn7s4g42w7g-utox-0.17.0

@peterhoeg peterhoeg merged commit 12d89a7 into NixOS:master Apr 30, 2018
@peterhoeg peterhoeg deleted the u/tox branch April 30, 2018 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterhoeg @Mic92 @GrahamcOfBorg