gnome-boxes: fix USB redirection (#39129) #39133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes USB redirection in gnome-boxes by ensuring that the required PolicyKit action policy file is installed in the spice-gtk package and adding that package to gnome-boxes propagatedUserEnvPkgs.
GrahamcOfBorg
added
6.topic: GNOME
jtojnar
requested changes
Apr 19, 2018
| @@ -24,6 +24,8 @@ in stdenv.mkDerivation rec { | |||
| meson ninja vala pkgconfig gettext itstool wrapGAppsHook gobjectIntrospection desktop-file-utils | |||
| ]; | |||
|
|
|||
| propagatedUserEnvPkgs = [ spice-gtk ]; | |||
There was a problem hiding this comment.
Could you add a comment mentioning that it is needed for installing the polkit rules
|
Thank you, looks good to me if you add the comment. |
|
Thanks, comment added. |
|
I really appreciate the quick turnaround on this. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes USB redirection in gnome-boxes by ensuring that the
required PolicyKit action policy file is installed in the spice-gtk
package and adding that package to gnome-boxes propagatedUserEnvPkgs.
Motivation for this change
USB redirection stopped working for me and I needed it.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)I'm running with these modifications on my x86_64 NixOS laptop.