notmuch: build with gmime2 for now #39146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please backport to 18.03 as well. |
|
Success on aarch64-linux (full log) Attempted: notmuch Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: notmuch Partial log (click to expand)
|
|
This PR will break notmuch show --decrypt. See
Subject: bug: notmuch show --decrypt leads to SIGSEGV
Date: Tue, 15 Aug 2017 10:37:31 -0700
on notmuch ML.
I would temporary disable tests instead.
|
|
@oxij can you check if disabling tests as in flokli/notmuch@f7dc4cf keeps |
|
Why not just set `doCheck = false;`?
|
|
Yes, you could use that as well to test whether If I understand
I followed the mailthread It looks like recent gmime-3 doesn't call the |
|
Success on x86_64-linux (full log) Attempted: notmuch Partial log (click to expand)
|
|
Let me cite myself from the thread
It fixes the SIGSEGV, but, as with my patch, without some more code
around those NULLs `notmuch search --format=sexp --decrypt` simply
produces empty bodies (`:body ()`) for suspect messages. That breaks
rendering of those messages in `notmuch.el` (it fails with some
exception and stops rendering the rest of the thread; which is better
than rendering no messages in the thread, but still very far from
ideal). This solution also doesn't print any content when it could (in
case of an invalid signature).
Compiling with gmime-3.0.1, on the other hand, works perfectly. It just
shows that the signature is invalid and that's it, the rest of the
message and the rest of the thread renders perfectly. The problem with
gmime-3.0.1, as my other message still stuck in moderation shows, is
that a lot of other tests fail with some silly differences in the
produced JSONs.
Did you check that encrypted threads render correctly with gmime2? Last time I checked, they did not.
|
|
Nah, I didn't use |
|
Is gmime2 with notmuch broken upstream as well?
From the conversations on ML I feel like gmime2 is kinda deprecated. It works for most things, but not for the advanced features (and I, for one, use said advanced features, so I'd like to keep them working).
So, if gmime3 update broke some tests I would just add `doCheck = false` to notmuch expression with a note to remove on update.
|
|
I simply wasn't sure if it's just the tests that broke or your "advanced features" as well. I will have a more detailed look on it in some hours. |
|
Ah. Hm. I don't think it's likely that things will really break if some tests fail with small output differences.
We could also just keep the previous version of gmime3 just for notmuch. (Which is the best solution, IMHO.)
|
|
@oxij looks like something between So no reason to try to build with gmime2 anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #39124
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)