Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update license for VSCode #39148

Closed
wants to merge 1 commit into from
Closed

Update license for VSCode #39148

wants to merge 1 commit into from

Conversation

thorerik
Copy link

@thorerik thorerik commented Apr 19, 2018 •
edited

Motivation for this change

Easier to find the package, and since it's MIT licensed, it doesn't make sense to hide it behind the unfree license.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@thorerik
Update license for VSCode
ab727b0 
Visual Studio Code is Licensed under MIT, and is hence not unfree
@adisbladis
Copy link
Member

adisbladis commented Apr 19, 2018 •
edited

Hi and thanks for your contribution!

We (nixpkgs) are not building VSCode from source but instead using binaries from Microsoft.
These binaries are NOT under the MIT license.

We need to start building it from source before we can change the license to MIT.

#26698

@adisbladis adisbladis closed this Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thorerik @adisbladis @GrahamcOfBorg