Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sit: better fix for aarch64 bug #40151

Merged
merged 1 commit into from May 8, 2018
Merged

sit: better fix for aarch64 bug #40151

merged 1 commit into from May 8, 2018

Conversation

yrashk
Copy link
Contributor

@yrashk yrashk commented May 7, 2018

Motivation for this change

Following further investigation of the original issue with aarch64 test failure for sit, a more elegant solution was found (one that wouldn't change the code)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented May 8, 2018

@GrahamcOfBorg build sit

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: sit

Partial log (click to expand)

cp: -r not specified; omitting directory 'target/release/examples'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/sr66wmwzhbrlg8qgsajkh8ypljak54vc-sit-0.3.2
shrinking /nix/store/sr66wmwzhbrlg8qgsajkh8ypljak54vc-sit-0.3.2/bin/sit-web
shrinking /nix/store/sr66wmwzhbrlg8qgsajkh8ypljak54vc-sit-0.3.2/bin/sit
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/sr66wmwzhbrlg8qgsajkh8ypljak54vc-sit-0.3.2/bin
patching script interpreter paths in /nix/store/sr66wmwzhbrlg8qgsajkh8ypljak54vc-sit-0.3.2
checking for references to /build in /nix/store/sr66wmwzhbrlg8qgsajkh8ypljak54vc-sit-0.3.2...
/nix/store/sr66wmwzhbrlg8qgsajkh8ypljak54vc-sit-0.3.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: sit

Partial log (click to expand)

cp: -r not specified; omitting directory 'target/release/deps'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/7rlfw19ss2zzjgjb40c6m0py5mrh4yr4-sit-0.3.2
shrinking /nix/store/7rlfw19ss2zzjgjb40c6m0py5mrh4yr4-sit-0.3.2/bin/sit
shrinking /nix/store/7rlfw19ss2zzjgjb40c6m0py5mrh4yr4-sit-0.3.2/bin/sit-web
strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7rlfw19ss2zzjgjb40c6m0py5mrh4yr4-sit-0.3.2/bin
patching script interpreter paths in /nix/store/7rlfw19ss2zzjgjb40c6m0py5mrh4yr4-sit-0.3.2
checking for references to /build in /nix/store/7rlfw19ss2zzjgjb40c6m0py5mrh4yr4-sit-0.3.2...
/nix/store/7rlfw19ss2zzjgjb40c6m0py5mrh4yr4-sit-0.3.2

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: sit

Partial log (click to expand)

          clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)


error: aborting due to previous error

error: Could not compile `sit-web`.

To learn more, run the command again with --verbose.
builder for '/nix/store/6mmkzjg3s6n4rd70chjrms8i1npxrnfp-sit-0.3.2.drv' failed with exit code 101
error: build of '/nix/store/6mmkzjg3s6n4rd70chjrms8i1npxrnfp-sit-0.3.2.drv' failed

@yrashk
Copy link
Contributor Author

yrashk commented May 8, 2018 via email

@xeji
Copy link
Contributor

xeji commented May 8, 2018

Thank you!

@xeji xeji merged commit ab4a04c into NixOS:master May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yrashk @xeji @GrahamcOfBorg