Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.phonenumbers: 8.9.3 -> 8.9.5 #40135

Merged
merged 1 commit into from May 7, 2018
Merged

pythonPackages.phonenumbers: 8.9.3 -> 8.9.5 #40135

merged 1 commit into from May 7, 2018

Conversation

fadenb
Copy link
Contributor

@fadenb fadenb commented May 7, 2018

Motivation for this change

https://github.com/googlei18n/libphonenumber/blob/master/release_notes.txt

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@fadenb fadenb requested a review from FRidh as a code owner May 7, 2018 17:54
@xeji
Copy link
Contributor

xeji commented May 7, 2018

@GrahamcOfBorg eval

@xeji
Copy link
Contributor

xeji commented May 7, 2018

@GrahamcOfBorg build python27Packages.phonenumbers python36Packages.phonenumbers

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.phonenumbers, python36Packages.phonenumbers

Partial log (click to expand)

testTollFree (tests.examplenumberstest.ExampleNumbersTest) ... ok
testUan (tests.examplenumberstest.ExampleNumbersTest) ... ok
testVoicemail (tests.examplenumberstest.ExampleNumbersTest) ... ok
testVoip (tests.examplenumberstest.ExampleNumbersTest) ... ok
testWhitespaceInNationalPrefixForParsing (tests.examplenumberstest.ExampleNumbersTest) ... ok

----------------------------------------------------------------------
Ran 27 tests in 1.573s

OK

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python27Packages.phonenumbers, python36Packages.phonenumbers

Partial log (click to expand)

testVoicemail (tests.examplenumberstest.ExampleNumbersTest) ... ok
testVoip (tests.examplenumberstest.ExampleNumbersTest) ... ok
testWhitespaceInNationalPrefixForParsing (tests.examplenumberstest.ExampleNumbersTest) ... ok

----------------------------------------------------------------------
Ran 27 tests in 27.593s

OK
/nix/store/0x0im51ddlhv07rrhaww6apmqqlzgd3p-python2.7-phonenumbers-8.9.5
/nix/store/p0imgnzp0zc3fic6n11ar2lcagbyjq1c-python3.6-phonenumbers-8.9.5

@xeji xeji merged commit 60a5276 into NixOS:master May 7, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python27Packages.phonenumbers, python36Packages.phonenumbers

Partial log (click to expand)

testTollFree (tests.examplenumberstest.ExampleNumbersTest) ... ok
testUan (tests.examplenumberstest.ExampleNumbersTest) ... ok
testVoicemail (tests.examplenumberstest.ExampleNumbersTest) ... ok
testVoip (tests.examplenumberstest.ExampleNumbersTest) ... ok
testWhitespaceInNationalPrefixForParsing (tests.examplenumberstest.ExampleNumbersTest) ... ok

----------------------------------------------------------------------
Ran 27 tests in 2.994s

OK

@fadenb fadenb deleted the pythonPackages.phonenumbers_8.9.5 branch May 8, 2018 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fadenb @xeji @GrahamcOfBorg