Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ext4magic: init at 0.3.2 #40148

Merged
merged 1 commit into from May 9, 2018
Merged

ext4magic: init at 0.3.2 #40148

merged 1 commit into from May 9, 2018

Conversation

rkoe
Copy link
Contributor

@rkoe rkoe commented May 7, 2018

Motivation for this change

Add ext4magic-package, which can undelete files on ext3/ext4.

This seems to be the only tool which can undelete files on ext3/ext4, since extundelete often crashes with a segmentation fault; and even if extundelete would work, ext4magic is more powerful.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@matthewbauer
Copy link
Member

@GrahamcOfBorg build ext4magic

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: ext4magic

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ext4magic

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xv8sffl19rfhp1z1jrvg289x95hgw7zc-ext4magic-0.3.2
shrinking /nix/store/xv8sffl19rfhp1z1jrvg289x95hgw7zc-ext4magic-0.3.2/sbin/ext4magic
gzipping man pages under /nix/store/xv8sffl19rfhp1z1jrvg289x95hgw7zc-ext4magic-0.3.2/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xv8sffl19rfhp1z1jrvg289x95hgw7zc-ext4magic-0.3.2/sbin
patching script interpreter paths in /nix/store/xv8sffl19rfhp1z1jrvg289x95hgw7zc-ext4magic-0.3.2
checking for references to /build in /nix/store/xv8sffl19rfhp1z1jrvg289x95hgw7zc-ext4magic-0.3.2...
moving /nix/store/xv8sffl19rfhp1z1jrvg289x95hgw7zc-ext4magic-0.3.2/sbin/* to /nix/store/xv8sffl19rfhp1z1jrvg289x95hgw7zc-ext4magic-0.3.2/bin
/nix/store/xv8sffl19rfhp1z1jrvg289x95hgw7zc-ext4magic-0.3.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ext4magic

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5xp272i6h37ky7qi2b337bsiy9nqgd87-ext4magic-0.3.2
shrinking /nix/store/5xp272i6h37ky7qi2b337bsiy9nqgd87-ext4magic-0.3.2/sbin/ext4magic
gzipping man pages under /nix/store/5xp272i6h37ky7qi2b337bsiy9nqgd87-ext4magic-0.3.2/share/man/
strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5xp272i6h37ky7qi2b337bsiy9nqgd87-ext4magic-0.3.2/sbin
patching script interpreter paths in /nix/store/5xp272i6h37ky7qi2b337bsiy9nqgd87-ext4magic-0.3.2
checking for references to /build in /nix/store/5xp272i6h37ky7qi2b337bsiy9nqgd87-ext4magic-0.3.2...
moving /nix/store/5xp272i6h37ky7qi2b337bsiy9nqgd87-ext4magic-0.3.2/sbin/* to /nix/store/5xp272i6h37ky7qi2b337bsiy9nqgd87-ext4magic-0.3.2/bin
/nix/store/5xp272i6h37ky7qi2b337bsiy9nqgd87-ext4magic-0.3.2

@matthewbauer matthewbauer merged commit 0481467 into NixOS:master May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rkoe @matthewbauer @GrahamcOfBorg